Allow deleting multiple files - #2475
Merged
Merged
Conversation
Whether a folder can be deleted is a question about the folder tree, which the collection already answers for parents, children and descendants. Having it here keeps the next caller from spelling the rule out a second time.
The selection bar gained a trash button next to the move button, which asks for confirmation and then destroys everything that is checked. Folders which still hold files or subfolders are refused by the server, so a selection containing one disables the button instead of failing halfway through the deletions.
Both file rows asked in a hardcoded German sentence, which also had a word twice. Each view now reads its own confirm_destroy, the way every other delete confirmation in the editor gets its wording.
The default prefix was missing the views segment, so the keys it looked up existed nowhere. Every subclass so far sets its own prefix, which is why nothing showed a missing translation yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also replace some hard coded German confirmation texts.