The sing beat, and a page a phone can actually use - #7
Merged
Conversation
The lyrics never appeared. rasterize picks the karaoke line *or* the caption strip, never both, and the karaoke line is half the size and sits up at his shoulder rather than under the ground. The preview drew the song's intro, in the caption strip, at caption size, forever — so the three lines somebody had just typed were never once on screen. Ported properly: same scale, same place, same 30-tick cycle, and the strip stays empty like it does in the file. Verified against a real render at four ticks — identical, both bands. Drag did nothing on a phone. A finger starting on the handle can't be told apart from a scroll until it has already moved, and by then the page has gone, so the gesture never reached dnd-kit: touch-action: none on the handle, and a touch sensor that waits 180ms. Hold then drag; move first and it scrolls, which is what a finger on a long page usually wants. The handle also got bigger, because 8px of tap target is a joke on glass. Keyboard sensor too — a list you can only reorder by dragging is a list some people can't reorder. And the page was 15px wider than the phone. Grid and flex children are min-width:auto, so they refuse to shrink under their content, and the canvas carries an intrinsic 1056px however hard w-full argues. min-w-0 where it matters: zero overflow on all three steps now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs, both found by using the thing rather than by any test I'd written.
The lyrics never appeared
rasterizepicks the karaoke line or the caption strip, never both — andthe karaoke line is half the size and sits up at his shoulder, not under the
ground. The preview drew the song's intro, in the caption strip, at caption
size, forever. So the three lines somebody had just typed were never once on
screen.
Ported properly: same scale, same place, same 30-tick cycle, and the strip
stays empty like it does in the file. Checked against a real render:
Identical, both bands, all four ticks.
Drag did nothing on a phone
A finger starting on the handle can't be told apart from a scroll until it has
already moved — and by then the page has gone, so the gesture never reached
dnd-kit.
touch-action: noneon the handle, plus a touch sensor that waits180ms: hold then drag, move first and it scrolls, which is what a finger on a
long page usually wants. The handle got bigger too; 8px of tap target is a joke
on glass.
Keyboard sensor while I was in there. A list you can only reorder by dragging
is a list some people can't reorder.
And the page was 15px wider than the phone
Grid and flex children are
min-width: auto, so they refuse to shrink belowtheir content — and the canvas carries an intrinsic 1056px however hard
w-fullargues.min-w-0where it matters. Zero overflow on all three stepsnow, measured, not eyeballed.