Fix/GitHub disconnect - #122
Open
DevOlabode wants to merge 5 commits into
Open
Conversation
DevOlabode
force-pushed
the
fix/github-disconnect
branch
from
August 28, 2026 06:20
a765983 to
9889411
Compare
ieliofficial
requested changes
Aug 30, 2026
ieliofficial
left a comment
ieliofficial
left a comment
Member
There was a problem hiding this comment.
Backend shape is right and both revoked paths on /storages are tested.
It only covers /storages though. /storage/name-availability (auth.js:117)
and /storage/create (auth.js:147) still answer a revoked token with a 400
and no GITHUB_AUTH_REVOKED code, so the frontend falls back to matching
the error string. Can those two use githubAccessRevoked() as well? That's
also what #121 asks for.
One other thing, not in the body: Cancel on Connect now signs you out
(App.jsx:376). Right for the revoked case, but is it right for someone
who just clicked Connect by mistake?
Those two and I'll merge.
…t and remove redundant checks in storage routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #121