docs(transformations): add OneLake external data examples - #3100
Conversation
Add example module YAML/SQL under examples/transformations and a Fabric-gated integration lifecycle test. Co-authored-by: Cursor <cursoragent@cursor.com>
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces examples and integration tests for deploying Fabric OneLake external data sources and transformations. The review feedback focuses on improving the robustness of the integration tests in CI/CD environments where a .env file may not be present, and adding missing type hints to the test code to comply with the repository style guide.
Use format as a Pydantic field, fix annotation shadowing on Python 3.12, harden ExternalDataSourceIO retrieve/iterate/get_id, add ACL Action enum, and fix test lint issues. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces example configurations and documentation for deploying Fabric OneLake external data sources and transformations, along with corresponding integration tests. The feedback suggests moving local imports in the integration test file to the top level to comply with the repository's import grouping style guide.
| from cognite_toolkit._cdf_tk.client.resource_classes.external_data_source import ( | ||
| ExternalDataSourceRequest, | ||
| OneLakeCredentialsWrite, | ||
| OneLakeLocationDescription, | ||
| OneLakeSettingsWrite, | ||
| ) |
There was a problem hiding this comment.
Local imports violate the repository style guide's rule on grouping imports at the top of the file. Please move this import to the top-level, grouped with other local application imports.
References
- The style guide requires imports to be grouped at the top of the file into three sections: standard library, third-party, and local application (lines 63-65). Placing imports inside functions or methods goes against this principle. (link)
b948d67
into
feat/toolkit-onelake-edc-deploy
1 participant
Description
Add examples and Fabric-gated integration coverage for OneLake external data sources.
Slice 3/3 — stacked on #3099.
Bump
Changelog
Added
examples/transformations/(ExternalDataSource YAML + Transformation + SQL)Made with Cursor