fix: normalize Windows backslashes in makePathRelative results - #53
Merged
Merged
Conversation
On Windows, fileSystemUtil.makePathRelative() returns paths using OS-native backslashes (e.g. resources\database\migrations\). When these are later used to build a BoxLang component path, the backslashes are not treated as delimiters and corrupt the class name, causing a ClassNotFoundBoxLangException. Wrap all three makePathRelative call sites in replace(..., "\\", "/", "all") to normalize to forward slashes before the paths are stored or forwarded, matching the same pattern already used in getInstalledBoxLangDriverSlugs(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pxe6woQNVSZ9kR9MdjxKRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, fileSystemUtil.makePathRelative() returns paths using
OS-native backslashes (e.g. resources\database\migrations). When
these are later used to build a BoxLang component path, the backslashes
are not treated as delimiters and corrupt the class name, causing a
ClassNotFoundBoxLangException. Wrap all three makePathRelative call
sites in replace(..., "\", "/", "all") to normalize to forward
slashes before the paths are stored or forwarded, matching the same
pattern already used in getInstalledBoxLangDriverSlugs().
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Pxe6woQNVSZ9kR9MdjxKRr