chore: update fullsend shim workflow#3392
Conversation
Update the shim workflow to match the current template in the .fullsend config repo.
|
🤖 Finished Review · ✅ Success · Started 10:06 AM UTC · Completed 10:09 AM UTC |
Review — commentVerdict: Comment — one medium-severity finding worth noting. SummaryThis PR removes the 16-line Apache License 2.0 copyright header (including the Findings1. License header removal creates inconsistency with all other workflow files — medium / styleFile: All nine other workflow files in
After this PR, The PR description states this brings the shim "back in sync" with the upstream template in the Suggested remediation: Either preserve the license header in this file to maintain consistency, or — if the intent is for the upstream template to manage this file — document the exception and consider a follow-up to align the template with the project's licensing convention. CorrectnessNo functional changes. The workflow YAML is valid and behavior is unchanged. SecurityNo security implications. No permissions, secrets handling, or trigger logic is modified. ScopeThe change is appropriately scoped — a single file with a single concern (header removal). |
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # lint-workflow-size: max-lines=280 |
There was a problem hiding this comment.
[medium] style/conventions
Removing the Apache 2.0 license header (including SPDX-License-Identifier tag) from fullsend.yaml makes it the only workflow file in .github/workflows/ without the standard copyright header. All 9 other workflow files retain it. This breaks the project established convention.
Suggested fix: Preserve the license header to maintain consistency with all other workflow files, or if the upstream template must omit it, document the exception and consider updating the template to include the header.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This PR updates the fullsend shim workflow to match the current template in the
.fullsendconfig repo.The shim content has drifted from the template — this brings it back in sync.