Skip to content

chore: update fullsend shim workflow#3392

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

chore: update fullsend shim workflow#3392
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:06 AM UTC · Completed 10:09 AM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — comment

Verdict: Comment — one medium-severity finding worth noting.

Summary

This PR removes the 16-line Apache License 2.0 copyright header (including the SPDX-License-Identifier: Apache-2.0 tag) from .github/workflows/fullsend.yaml. No functional workflow changes are made — the jobs, permissions, triggers, and all logic remain identical.

Findings

1. License header removal creates inconsistency with all other workflow files — medium / style

File: .github/workflows/fullsend.yaml, lines 1–16 (removed)

All nine other workflow files in .github/workflows/ retain the standard Apache 2.0 copyright header with SPDX identifier:

  • auto-merge.yaml
  • checks-codecov.yaml
  • codeql.yaml
  • label-pr-size.yaml
  • lint.yaml
  • release.yaml
  • scorecard.yml
  • update-go-containerregistry.yaml
  • website.yaml

After this PR, fullsend.yaml would be the only workflow file without the header. The repository is Apache-2.0 licensed (top-level LICENSE file), so the per-file header is not legally required, but removing it from a single file breaks the project's established convention and removes the machine-readable SPDX-License-Identifier tag.

The PR description states this brings the shim "back in sync" with the upstream template in the .fullsend config repo. However, the template's convention (no header) conflicts with this repository's convention (all files have headers). If the external reconcile tooling (reconcile-repos.sh) will strip the header on subsequent syncs anyway, consider instead updating the template to include the header so both conventions align.

Suggested remediation: Either preserve the license header in this file to maintain consistency, or — if the intent is for the upstream template to manage this file — document the exception and consider a follow-up to align the template with the project's licensing convention.

Correctness

No functional changes. The workflow YAML is valid and behavior is unchanged.

Security

No security implications. No permissions, secrets handling, or trigger logic is modified.

Scope

The change is appropriately scoped — a single file with a single concern (header removal).

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

#
# SPDX-License-Identifier: Apache-2.0

# lint-workflow-size: max-lines=280

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] style/conventions

Removing the Apache 2.0 license header (including SPDX-License-Identifier tag) from fullsend.yaml makes it the only workflow file in .github/workflows/ without the standard copyright header. All 9 other workflow files retain it. This breaks the project established convention.

Suggested fix: Preserve the license header to maintain consistency with all other workflow files, or if the upstream template must omit it, document the exception and consider updating the template to include the header.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 53.61% <ø> (-0.01%) ⬇️
generative 17.18% <ø> (ø)
integration 28.36% <ø> (ø)
unit 71.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants