fix: rebuild dist on prepack so publishes carry the bumped version - #32
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No issues found — approved ✅. This PR wires up the makage dist-layout publishing flow for the six packages on the publish-from-
No high-confidence defects were found; two low-confidence observations (unguarded source manifest read, and the published tarball shipping the Reviewed commit: fa71044 |
Resolve workspace: ranges into real semver in dist/package.json, rebuild dist on prepack, and guard both properties with pnpm check:dist-manifests.
4e84d3b to
bce4819
Compare
Summary
One line per makage package, matching what every
constructive-io/constructivepackage already does:+"prepack": "npm run build"That is why last night's
lerna publishonly landed the five@constructive-io/*packages. These six publish fromdist,lerna versionbumps only the source manifest, and nothing rebuiltdist— so npm got the pre-bump version number with the new code (blocks-schema@0.2.1is really 0.3.0's code,blocks-renderer@0.1.2is really 0.2.0's) andjson-rendererfailed outright because its dist still said0.0.1. The same missing rebuild is why"json-renderer": "workspace:^"reached npm: lerna resolves workspace ranges in the source manifest, andprepackis what copies that resolved manifest intodist.@constructive-io/clipublishes with^5.18.3deps for exactly this reason.json-renderer@0.1.0and the other five bumped versions are still unpublished and now publish correctly.blocks-schema@0.2.1andblocks-renderer@0.1.1/0.1.2are immutable and carryworkspace:deps — worthnpm deprecate-ing once the good versions are out.pnpm checkpasses.Link to Devin session: https://app.devin.ai/sessions/027937d092794c92a31c6ee49c513f59
Requested by: @pyramation