Adding missing @Override annotations. Some refactoring

[unv-unv]

No description provided.

[unv-unv]

@claude review pr with inline comments

[github-actions]

Claude finished @unv-unv's task in 2m 36s —— View job

---

PR Review: Adding missing @Override annotations

• Read PR diff and understand refactoring pattern
• Check for correctness issues / regressions
• Post inline review comments

I reviewed all 100 changed files. This is a mechanical, low-risk cleanup of the generated DOM interfaces in api/.../dom/. Two things happen in every file:

1. Removal of extra blank lines (accounts for the bulk of the -1921 deletions).
2. Addition of @Override to methods that override a parent interface (Task, SimpleItem, DomElement, etc.).

✅ Correctness

• No method declarations were removed — spot-checked the largest deletions (Link.java -119, CL.java, Vbc.java): method counts are identical before/after (e.g. Link.java = 117 both sides). The deletions are purely blank lines.
• The @Override placements are accurate. I cross-checked against the parent interfaces. For example in ApplicationDefinition (extends SimpleItem), @Override is correctly added to getInclude/getExclude/getRemove/getUpdate/getLabel/getSubType/getDependentUpon/getGenerator/getLink and correctly not added to non-inherited members like getGroup(), getLastGenOutput(), getCustomToolNamespace(). Task-derived types get @Override on getCondition/getContinueOnError/getArchitecture/getRuntime/getOutputs/addOutput. Looks right throughout.

⚠️ One issue — mixed indentation (tabs → spaces)

The ~616 newly added @Override lines (and the method signatures re-indented alongside them) use 4 spaces, while the entire codebase uses tabs. This produces mixed indentation within a single declaration — e.g. a tab-indented @Nonnull directly above a space-indented @Override:

\t@Nonnull
    @Override
    GenericAttributeValue<String> getInclude();

I left inline suggestion comments on ApplicationDefinition.java and Compile.java you can apply with one click. The real fix is to set the IDE/formatter to tabs and reformat, since this pattern repeats across all 100 files. Worth normalizing before merge to keep the generated interfaces consistent with the rest of the tree.

Verdict

Functionally correct and safe. Only the tabs-vs-spaces inconsistency should be addressed. Since these are generated files, ideally the code generator's template would emit @Override + tabs so future regenerations stay consistent.
· overrides-1

[github-actions]

The added @Override and the re-indented signature use 4 spaces, but this file (and the rest of the codebase) is indented with tabs. @Nonnull above is tab-indented while @Override below is space-indented — mixed indentation within a single declaration.

Suggested change

	@Override
	GenericAttributeValue<String> getInclude();
	@Override
	GenericAttributeValue<String> getInclude();

The same tab→space inconsistency applies to all ~616 @Override lines added across the 100 files in this PR. Configuring the IDE/formatter to use tabs would keep the generated DOM interfaces consistent.

[github-actions]

@Override is correctly placed here (Compile extends SimpleItem, which declares getInclude()), but it's indented with 4 spaces while the surrounding annotations (@Nonnull, @Convert) use tabs.

Suggested change

	@Override
	@Override