Skip to content

Use PR head commits for conformance artifacts #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucarlig merged 1 commit into from
Sep 7, 2026
Merged

Use PR head commits for conformance artifacts #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.2
with:
# Match the PR revision selected by /conformance.
ref: ${{ github.event.pull_request.head.sha || github.sha }}
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2.9.1
- name: Build the workspace
Expand All @@ -87,10 +90,10 @@ jobs:
- name: Upload the conformance binary
uses: actions/upload-artifact@v7.0.1
with:
name: contextforge-data-plane-conformance-${{ github.sha }}
name: contextforge-data-plane-conformance-${{ github.event.pull_request.head.sha || github.sha }}
path: target/debug/contextforge-data-plane
if-no-files-found: error
retention-days: 1
retention-days: 90

bench:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
REPOSITORY: ${{ github.repository }}
run: >-
gh api "repos/$REPOSITORY/pulls/$PR_NUMBER"
--jq '"head_sha=\(.head.sha)\nmerge_sha=\(.merge_commit_sha)"'
--jq '"head_sha=\(.head.sha)"'
>> "$GITHUB_OUTPUT"

- name: Publish the pending PR status
Expand All @@ -56,7 +56,7 @@ jobs:
with:
fetch-depth: 0
persist-credentials: false
ref: ${{ steps.revision.outputs.merge_sha }}
ref: ${{ steps.revision.outputs.head_sha }}

- uses: taiki-e/install-action@v2.75.27
with:
Expand Down
6 changes: 4 additions & 2 deletions _context/wiki/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@ repository keeps only the CI invocation, Make targets, and expected findings.

Comment exactly `/conformance` on a pull request to run the **Conformance**
Actions workflow. Only repository owners, members, and collaborators can start
it. The workflow acknowledges the command, tests the pull request merge commit,
and reports the final result back to the pull request. It runs the modern client
it. The workflow acknowledges the command, tests the pull request head commit,
and reports the final result back to the pull request. CI builds and names the
conformance binary artifact using that same head SHA and retains it for 90 days,
so changes to `main` do not invalidate the artifact. It runs the modern client
and modern server eras through the external dataplane in standalone mode. This
starts Redis, the dataplane, nginx, and the official fixture without the control
plane. The harness discovers the fixture's tools, resources, templates, and
Expand Down