Qualify the cgp_auto_dispatch matcher call, and test open on a later parameter - #268
Merged
Merged
Conversation
…parameter The generated dispatch method called the matcher as `Matcher::compute`, which is ambiguous with `E0034` in any module that also imports `CanCompute` or `CanComputeAsync`. Name the provider trait with inferred arguments instead, and add a test that imports both consumer traits. Also add a snapshot and behavioral test for `open` keys whose first segment is a per-entry generic, dispatching on the input alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated dispatch method called the matcher as
Matcher::compute, which is ambiguous withE0034in any module that also importsCanComputeorCanComputeAsync. Name the provider trait with inferred arguments instead, and add a test that imports both consumer traits.Also add a snapshot and behavioral test for
openkeys whose first segment is a per-entry generic, dispatching on the input alone.