chore(deps-dev): bump tailwindcss from 3.4.17 to 4.3.3 - #396
Conversation
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) from 3.4.17 to 4.3.3. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.3.3/packages/tailwindcss) --- updated-dependencies: - dependency-name: tailwindcss dependency-version: 4.3.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e76a2e7 to
d7501ac
Compare
v4 ships no `tailwindcss` binary in the main package, so `npm run build-css` failed with "tailwindcss: not found" and CI never produced a stylesheet. Adds @tailwindcss/cli, which restores that bin - the npm scripts are unchanged. Stylesheet entry moves to the v4 form: `@import "tailwindcss"` replaces the three @tailwind directives, and an explicit `@config` keeps tailwind.config.js authoritative (custom colours, gradient keyframes, content globs and darkMode: 'class'), which v4 no longer auto-discovers. Renames utilities that v4 dropped or redefined, in input.css and in the templates: flex-shrink-0 -> shrink-0 flex-grow -> grow shadow-sm -> shadow-xs outline-none -> outline-hidden rounded -> rounded-sm bg-black bg-opacity-50 -> bg-black/50 and the trailing-bang @apply form for !important. Bare `rounded` was rewritten only inside class attributes, so the identically named JavaScript locals in shopping_list.html are untouched. Verified by diffing generated CSS against a v3 build: every one of the 453 class tokens used in the templates, and every utility in the server-rendered HTML, still resolves to a rule.
|
Review: Tailwind CSS v3 to v4 migration Nice work on this. Dependabot only bumped the version number in d7501ac, and the actual v3 to v4 utility-class migration in fb1ace6 (templates + input.css) was done carefully by hand. The renames match the official v4 upgrade guide and are applied consistently:
Bug: one bg-opacity-50 usage was missed. static/js/keyboard-shortcuts.js line 123 still builds the modal backdrop class as: modal.className = 'fixed inset-0 z-50 flex items-center justify-center bg-black bg-opacity-50'; bg-opacity-* utilities were removed in Tailwind v4 (superseded by the /opacity modifier), so this class will no longer generate any CSS. The keyboard-shortcuts modal backdrop will render as fully opaque black instead of a translucent overlay. This is the exact pattern that was correctly migrated elsewhere in this same PR (see templates/edit.html and templates/pantry.html, where bg-black bg-opacity-50 becomes bg-black/50), just missed here because it is inside a JS template string rather than an .html file. Since static/**/*.js is in the Tailwind content globs, this is a one-line fix: modal.className = 'fixed inset-0 z-50 flex items-center justify-center bg-black/50'; I checked the rest of static/js/ for the same pattern (bg-opacity-, flex-shrink, flex-grow) and did not find any other misses. This looks like the only one. Minor observations (non-blocking):
Recommend fixing the keyboard-shortcuts.js backdrop class before merging; otherwise this looks good to go. |
Bumps tailwindcss from 3.4.17 to 4.3.3.
Release notes
Sourced from tailwindcss's releases.
... (truncated)
Changelog
Sourced from tailwindcss's changelog.
... (truncated)
Commits
c2b24dd4.3.3 (#20334)e48c5e8Fix weird character rendering on Windows with Japanese locale (#20318)35a3e9cAlways produce\<length>value when optimizing--spacing(0)(#20319)4af47fbFix hues in achromatic theme colors to benone(#20314)5835691Handle CSS nesting natively (#20124)67c745eFix bug in attribute selector parsing (#20303)2683903Support fractional opacity modifiers for named shadow sizes (#20302)04588b1Fix theme() in JS plugins returning unresolved object instead of DEFAULT valu...b53fa09fix: exclude iframes from focus-visible auto outline in Preflight (#20292)ef79119Bump dependencies (#20300)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for tailwindcss since your current version.