Return false for zero in i32::{is_positive,is_negative} specs#171
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes unsoundness in Thrust’s Rust-stdlib extern specs by correcting the 0 boundary case for i32::is_positive and i32::is_negative (issue #170), aligning the model with real Rust behavior so 0 is neither positive nor negative.
Changes:
- Update
_extern_spec_i32_is_positivepostcondition to makeresult == trueiffx > 0. - Update
_extern_spec_i32_is_negativepostcondition to makeresult == trueiffx < 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
707
to
711
| #[thrust_macros::requires(true)] | ||
| #[thrust_macros::ensures((x < 0 && result == false) || (x >= 0 && result == true))] | ||
| #[thrust_macros::ensures((x <= 0 && result == false) || (x > 0 && result == true))] | ||
| fn _extern_spec_i32_is_positive(x: i32) -> bool { | ||
| i32::is_positive(x) | ||
| } |
Comment on lines
714
to
718
| #[thrust_macros::requires(true)] | ||
| #[thrust_macros::ensures((x <= 0 && result == true) || (x > 0 && result == false))] | ||
| #[thrust_macros::ensures((x < 0 && result == true) || (x >= 0 && result == false))] | ||
| fn _extern_spec_i32_is_negative(x: i32) -> bool { | ||
| i32::is_negative(x) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #170