CI: install remotes when the runner has not - #18
Merged
Conversation
macos-latest moved to arm64 and r-ci's macOS bootstrap stopped leaving `remotes` behind. ./run.sh install_deps calls it directly, so the dependency step failed 0.16s in, before any package code was parsed, with "there is no package called remotes". Two things made that worse than it looks. It is identical across every repo on this CI, so three unrelated PRs all read red at once and none of the redness was about their contents. And fail-fast cancelled the Linux leg, which is the leg that actually gates these packages -- so the run reported failure while never running the tests that matter. Guarded on absence, so it is a no-op on Linux and removes itself when upstream ships the fix. Pinning macos-13 would also work and would quietly keep us on an x86_64 image indefinitely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-latestmoved to arm64 and r-ci's macOS bootstrap stopped leavingremotesbehind../run.sh install_depscalls it directly, so the dependency step failed 0.16s in, before any package code was parsed:Two things made that worse than it looks:
The fix is guarded on absence, so it is a no-op on Linux and deletes itself the day upstream ships a fix. Pinning
macos-13would also work, and would quietly keep us on an x86_64 image indefinitely.Root cause is upstream in
eddelbuettel/github-actions/r-ci, not here.