MB-44253: Remove try/catch from Executor*::runTask methods - #14
Closed
jimwwalker wants to merge 1 commit into
Closed
jimwwalker wants to merge 1 commit into
jimwwalker wants to merge 1 commit into
Conversation
owend74
approved these changes
Sep 4, 2026
Slightly adapted Dave Rigby's patch: commit 3d4519d Author: Dave Rigby <daver@couchbase.com> Date: Thu Feb 11 14:01:47 2021 +0000 MB-44253: Remove try/catch from Executor*::runTask methods These try/catch blocks prevent unhandled exceptions in GlobalTasks from triggering std::terminate, and in turn generating a Breakpad minidump with the state of the process when the exception was thrown (as opposed to where it was caught). Started a discussion with Folly about a more generic way to address this (i.e. making the try/catch somehow optional) - see facebook#1525 - but in the short-term simply remove the invokeCatchingExns() wrapper from our branch. (Note: Currently we only use ThreadPoolExecutor and hence we only /need/ to change that one, but for consistency / possible future use change all instances). Additionally disable the two unit tests which assert the removed exception-catching behaviour (they would now std::terminate): - ThreadedExecutorTest.exception - SerialExecutorTest/*.ExecutionThrows
jimwwalker
force-pushed
the
v2026.08.31.00-couchbase
branch
from
September 4, 2026 15:14
4ca44af to
4f15ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly adapted Dave Rigby's patch:
commit 3d4519d
Author: Dave Rigby daver@couchbase.com
Date: Thu Feb 11 14:01:47 2021 +0000