Skip to content

docs: let the shared styles bring the fonts - #460

Merged
2bndy5 merged 1 commit into
mainfrom
chore/match-hub-fonts
Sep 25, 2026
Merged

2bndy5 merged 1 commit into
mainfrom
chore/match-hub-fonts

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

cpp-linter/cpp-linter.github.io#67 moved the hub's look (colors, light header and fonts) into the shared stylesheet these docs already load. It is live, so this site now uses the hub's self-hosted fonts.

Material's default Roboto is still requested from Google Fonts on every page and never used. This sets theme.font: false, as cpp-linter/cpp-linter-action#489 did.

Checked that docs/mkdocs.yml still parses with theme.font set to false. The full docs build needs the Rust bindings, so it runs in CI.

Summary by CodeRabbit

  • Style
    • The documentation site now uses shared font styling rather than the theme’s built-in font.

The shared styles from cpp-linter.github.io now carry the hub's look,
fonts included, so Material's Roboto was downloaded and never used.
`theme.font: false` drops the request to Google Fonts.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 02a4f8ec-d9bf-469e-93ee-f5bdf916f7d7

📥 Commits

Reviewing files that changed from the base of the PR and between d593f6a and d3319a2.

📒 Files selected for processing (1)
  • docs/mkdocs.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The MkDocs Material configuration disables the theme’s built-in font. A comment notes that shared styles provide fonts.

Changes

MkDocs theme configuration

Layer / File(s) Summary
Disable the built-in font
docs/mkdocs.yml
The configuration disables the theme’s built-in font and notes that shared styles provide fonts.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to d3319

The documentation continues to use the intended fonts through the shared stylesheet, so this change has no identified user-facing regression and is ready to merge.

Architecture Summary

Architecture risk: 🔵 Low · up to d3319

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/mkdocs.yml: Adds a comment about shared font styles and disables the MkDocs Material theme’s built-in font.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: disabling Material's default font loading so shared styles provide the documentation fonts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shenxianpeng shenxianpeng added the documentation Improvements or additions to documentation label Sep 25, 2026
@2bndy5
2bndy5 merged commit 5ab2be3 into main Sep 25, 2026
20 checks passed
@2bndy5
2bndy5 deleted the chore/match-hub-fonts branch September 25, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants