docs: let the shared styles bring the fonts - #460
Conversation
The shared styles from cpp-linter.github.io now carry the hub's look, fonts included, so Material's Roboto was downloaded and never used. `theme.font: false` drops the request to Google Fonts.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe MkDocs Material configuration disables the theme’s built-in font. A comment notes that shared styles provide fonts. ChangesMkDocs theme configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The documentation continues to use the intended fonts through the shared stylesheet, so this change has no identified user-facing regression and is ready to merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cpp-linter/cpp-linter.github.io#67 moved the hub's look (colors, light header and fonts) into the shared stylesheet these docs already load. It is live, so this site now uses the hub's self-hosted fonts.
Material's default Roboto is still requested from Google Fonts on every page and never used. This sets
theme.font: false, as cpp-linter/cpp-linter-action#489 did.Checked that
docs/mkdocs.ymlstill parses withtheme.fontset to false. The full docs build needs the Rust bindings, so it runs in CI.Summary by CodeRabbit