fix(service-web): resolve getLocale error in Client Components - #388
Merged
Merged
Conversation
- useLocale from next-intl instead of getLocale from next-intl/server in RankBadge - add RankBadge unit tests - fix @darun/utils-router mocks in affected test files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kang-heewon
enabled auto-merge (squash)
September 18, 2026 15:24
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RankBadgefrom async server component (next-intl/server'sgetLocale) to synchronous component usinguseLocale()fromnext-intlgetLocale is not supported in Client ComponentswhenRankBadgeis rendered in client components (ProductItem,ProductCard)RankBadgeunit tests@darun/utils-routerabstraction across affected testsVerification
pnpm lintpassed (67/67)pnpm typecheckpassed (67/67)pnpm testpassed (66/66)pnpm --filter service-web buildpassed