fix(billing-core): round decimal money exactly - #2883
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-09-22T17:50:15.353Z · Commit: dd2f28b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MoneyAPI unchanged and publish the behavior correction as a patch changeset for@croco/billing-core.Closes #2472
Validation
1.005 USDproduced100instead of101.Moneysuite: 16/16 passed; full@croco/billing-coresuite: 184/184 passed.@croco/billing-corelint, typecheck, and build passed.pnpm pr-review-companion -- --base origin/trunk --head HEAD --run-required-checkspassed, including architecture policy, public API drift, andpnpm check.Integration
dd2f28b51133d77e6b27ecd3632c4dab5a1702d83ae15edb806855391cb0a5698f1ff0a1d7ff4c0100fe49487a3a5edfc736a58096fcdd6de1c20276audit-drizzlesource, tests, documentation, and its changeset; it does not interact with the billing-core decimal conversion contract, and GitHub reports the PR conflict-free.