-
Notifications
You must be signed in to change notification settings - Fork 1
fix(problems-core): reject Problem constructors that drop Error causes #2897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,256
−1
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
3cf2583
fix(problems-core): reject Problem constructors that drop Error causes
kang-heewon 4994b8a
fix(problems-core): detect masked Error causes in registry checks
kang-heewon af7c975
fix(problems-core): reject causes masked through wrapped and rebound …
kang-heewon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| { | ||
| "schemaVersion": 1, | ||
| "baselineEntryCount": 9, | ||
| "entries": [ | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/auth-better-auth/src/libs/problems/BetterAuthAuthenticationProblem.ts", | ||
| "className": "BetterAuthAuthenticationProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing upstream error is reduced to redacted status and message evidence; forwarding behavior is deferred to the auth adapter's own fix.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/auth-clerk/src/libs/problems/ClerkProblems.ts", | ||
| "className": "ClerkTokenVerificationProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing Clerk verification failure does not retain the upstream error; a package-specific fix must review sensitive cause handling.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/auth-clerk/src/libs/problems/ClerkProblems.ts", | ||
| "className": "ClerkTokenVerificationUpstreamProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing Clerk upstream failure does not retain the upstream error; a package-specific fix must review sensitive cause handling.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/batch-qstash/src/libs/problems/QStashBatchProblems.ts", | ||
| "className": "QStashBatchPublishProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing QStash batch failure records classified and redacted evidence without retaining the upstream Error; adapter repair is separate.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/events-core/src/libs/problems/EventsProblems.ts", | ||
| "className": "EventAfterCommitPublishFailedProblem", | ||
| "parameter": "observerError", | ||
| "owner": "framework-error-handling", | ||
| "reason": "The primary cause is forwarded; this optional second failure remains available as the observerError field rather than replacing the primary Error.cause.", | ||
| "expiresOn": "2026-12-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/metering-core/src/libs/problems/RedisProblem.ts", | ||
| "className": "RedisProblem", | ||
| "parameter": "originalError", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing Error-or-string input only contributes originalMessage; the metering package must preserve Error.cause in an Error-narrowed branch.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/metering-upstash/src/libs/problems/UpstashMeteringProblems.ts", | ||
| "className": "UpstashMeteringUpstreamProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing Upstash metering failure records classified and redacted evidence without retaining the upstream Error; adapter repair is separate.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/ratelimit-upstash/src/libs/problems/RateLimitUpstashProblems.ts", | ||
| "className": "UpstashRateLimitUpstreamProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing Upstash rate-limit failure records classified and redacted evidence without retaining the upstream Error; adapter repair is separate.", | ||
| "expiresOn": "2026-10-24" | ||
| }, | ||
| { | ||
| "code": "problem-cause-not-forwarded", | ||
| "file": "packages/tasks-qstash/src/libs/problems/QStashTaskProblems.ts", | ||
| "className": "QStashTaskPublishProblem", | ||
| "parameter": "error", | ||
| "owner": "framework-error-handling", | ||
| "reason": "Existing QStash task failure records classified and redacted evidence without retaining the upstream Error; adapter repair is separate.", | ||
| "expiresOn": "2026-10-24" | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.