fix(openapi-spec): honor declared success statuses in generated responses

[kang-heewon]

Summary

successStatus declared on a route now reaches the extracted route contract, OpenAPI success response, JSON success response coverage, generated client, and HTTP transport. Routes without an explicit status retain their existing 200 response for JSON and 204 response for an empty result. A route with an output schema cannot declare bodyless 204 or 205.

Closes #2316.

Validation

Elevated profile on head cc7fe332cbf76fcca4ac8516b26a2cc490ae9620. Independent code review and verifier reviews passed with no actionable findings.

• Negative control: the new declared-201 and bodyless-response cases failed before the fix and pass after it.
• Focused protocols-core, openapi-spec, and transports-http suites pass; the end-to-end round trip checks a generated 201 client response and the real HTTP response.
• Full build (238/238 tasks), full typecheck (239/239 tasks), and a full test rerun (239/239 tasks) passed locally on the initial head. The updated head passed affected-package tests, builds, typechecks, lint, and pre-commit checks, plus the full pre-push test and typecheck gates (239/239 tasks each).
• Architecture policy, public API snapshot, and generated API docs trigger checks pass. The first PR CI candidate found a strict-contract baseline drift: 38 existing emitter diagnostics moved lines and one new index-signature diagnostic appeared. The new lookup was corrected, the baseline changed only line numbers, and local pnpm strict-contract-typecheck passes with 0 added and 0 removed diagnostics. The updated PR CI will validate the merge candidate.

Visual evidence

The generated RouteIR documentation was checked at 1280×720 and 390×844, with no console errors or horizontal overflow.

Integration

• Head: cc7fe332cbf76fcca4ac8516b26a2cc490ae9620; current base: 67a0380e0a52d44a20039d806920876c6f6ecadc.
• The conflict-free combined tree is 757f710452eff7a908d82e1244a231d137299a97. The latest base commit changes only webhook retry files and a changeset.
• The prior candidate CI run 36013252956 failed strict-contract-typecheck; generated-apps and split-validation-shadow failures followed from that gate. The new head fixes this cause.

[coderabbitai]

Warning

Review limit reached

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6fb6cbaa-38a7-4778-8076-91f7bfe8f51f

📥 Commits

Reviewing files that changed from the base of the PR and between 3342494 and cc7fe33.

📒 Files selected for processing (13)

• .changeset/calm-status-contracts.md
• packages/docs/src/content/docs/api/protocols-core/src/interfaces/RouteIR.md
• packages/openapi-spec/src/libs/emitOpenAPI.ts
• packages/openapi-spec/src/tests/emitOpenAPI.spec.ts
• packages/openapi-spec/src/tests/round-trip.spec.ts
• packages/protocols-core/src/libs/ContractGraph.ts
• packages/protocols-core/src/libs/RouteIR.ts
• packages/protocols-core/src/libs/extractRouteIR.ts
• packages/protocols-core/src/tests/ContractGraph.spec.ts
• packages/protocols-core/src/tests/extractRouteIR.spec.ts
• packages/transports-http/src/libs/CrocoRouteRegistrar.ts
• packages/transports-http/src/tests/CrocoApp.spec.ts
• tsconfig/contract-strict.baseline.json

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-24T14:34:17.690300Z	e9b9028	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9b9028f17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

📊 Benchmark Results

✅ All benchmarks passed

Benchmark	p75	Threshold	Baseline	vs Baseline	Status	Notes
CrocoApp constructor	65.7μs	30.0ms	8.2μs	+703.6%	❌	-
CrocoApp lambdaHandler (10 controllers)	2.0ms	50.0ms	258.4μs	+690.6%	❌	-
Lambda cold-start simulation	2.3ms	80.0ms	418.1μs	+442.3%	❌	-
Lambda cold-start with headers	1.8ms	80.0ms	369.7μs	+377.9%	❌	-
Lambda cold-start with binary body	1.6ms	80.0ms	339.1μs	+368.4%	❌	-
Lambda cold-start with query params	1.6ms	80.0ms	301.3μs	+419.6%	❌	-
Lambda cold-start with authorizer context	1.5ms	80.0ms	299.8μs	+415.3%	❌	-
Lambda cold-start realistic scenario	1.6ms	80.0ms	299.2μs	+425.6%	❌	-
EventBusConfig.start (10 handlers)	1.7μs	10.0ms	1.4μs	+15.4%	✅	-
EventPublisher.publishNow single event	1.8μs	2.0ms	1.7μs	+6.5%	✅	-
DefaultHandlerResolver.resolve × 10	0.1μs	5.0ms	0.1μs	+0.0%	✅	-
Container.get singleton (cold)	94.1μs	5.0ms	70.3μs	+33.9%	❌	-
Container.register × 50 components	3.2ms	10.0ms	3.2ms	-1.4%	✅	-
Container.validate (50 components)	3.9ms	20.0ms	3.4ms	+15.0%	✅	-
Container.get singleton (warm)	1.4μs	500.0μs	1.6μs	-17.1%	✅	-
TelemetryRuntime.init (lambda preset)	12.9μs	200.0ms	1.1ms	-98.8%	✅	-
lambdaPreset config creation	1.5μs	2.0ms	1.4μs	+2.9%	✅	-

_{Updated: 2026-09-24T15:20:47.452Z · Commit: cc7fe33}