fix(framework-config): distinguish invalid environment values from missing settings - #2902
Conversation
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33bedd9081
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-09-24T16:50:09.423Z · Commit: c4e533a |
Summary
ConfigValidationProblemAPI reference and include a patch changeset for@croco/framework-config.Closes #2323
Validation
@croco/framework-configtests passed 75/75; package lint, typecheck, and build passed.pnpm buildpassed 238/238 tasks.pnpm public-api:check,pnpm docs:api:check, andpnpm changeset-required:checkpassed.pnpm checkpassed 26 gates with one not applicable; its Problem Registry gate reports missing codes in event and context packages outside this PR's diff. Final-head CI passedrepository-contracts. A direct Problem Registry check on the combined tree with trunk7d9c92b6aa841e782b620ea6a202b3bf0f847a84passed with 794 codes and 762 discoveries; the later trunk change left the registry artifacts unchanged.Integration
Head:
c4e533a0589ceaaee5142f1e3862454e23910747.Final pre-merge trunk tip:
b8f4a48aebfcb971e1aec4cd28cc0aafb9512f1a; GitHub reported no conflict. The combined candidate treea430d253fbea39b71d6cf68ea2ccdd902de1f701passed verification-manifest (59/59), CI performance budget (43/43), and CI workflow (68/68) tests. All required and impact-selected CI checks passed on the final head.Ordinary squash merge completed as
9cb6b878ea0a1076acfbc71e04a7baa418f01261.Visual evidence
The generated API page was inspected at 1280×720 and 390×844. The
diagnosticsparameter is visible, with no page or console errors or horizontal overflow.ConfigValidationProblem, 1280×720:ConfigValidationProblem, 390×844: