Repository navigation
docker/zig.sh: bump cargo-zigbuild 0.17.5 -> 0.23.4 so the zig image builds with Rust >= 1.98 (--fix-cortex-a53-843419) - #1805
Open
glaziermag wants to merge 1 commit into
Open
glaziermag wants to merge 1 commit into
glaziermag wants to merge 1 commit into
Conversation
glaziermag
force-pushed
the
zigbuild-0-23
branch
from
September 26, 2026 01:50
a4c3f5b to
ebbb052
Compare
Member
|
Please remove the co-authored-by for claude. This change is fine, but I don't want the implication of the attribution in this repo. This change is very small and there's no logic changed, only fixes. |
Rust 1.98.0 passes `-Wl,--fix-cortex-a53-843419` to the linker for every AArch64 Linux target (rust-lang/rust#155453). cargo-zigbuild 0.17.5, pinned in the zig image, rejects it (`unsupported linker arg`), so the `zig` CI job has failed at "Test Zig Image" on every push to main since 2026-08-20. cargo-zigbuild filters the argument since 0.23.0 (rust-cross/cargo-zigbuild#452). The release archives are now `cargo-zigbuild-<triple>.tar.xz` under the rust-cross organisation and unpack into a `cargo-zigbuild-<triple>/` directory; prebuilt Linux binaries exist only for x86_64 (gnu, musl) and aarch64 (gnu), so linux/arm64 uses the gnu build and linux/386 falls back to `cargo install`.
glaziermag
force-pushed
the
zigbuild-0-23
branch
from
October 2, 2026 00:02
ebbb052 to
47a82bc
Compare
Author
|
Removed. The branch is now a single commit (47a82bc) with no co-authored-by trailer; the diff is unchanged. Since merge commits here carry the PR description, I also dropped the "Generated with" footer line from it. The one-line disclosure is still in the description; tell me if you would rather that stay out of the merge message too and I will move it to a comment. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zigtarget of theCIworkflow has failed at "Test Zig Image" on every push tomainsince Rust 1.98.0 (2026-08-20). The image installs cargo-zigbuild 0.17.5 (docker/zig.sh, unchanged since 2024-04), whosezig ccwrapper rejects the-Wl,--fix-cortex-a53-843419linker argument that rustc now passes for every AArch64 Linux target (rust-lang/rust#155453, milestone 1.98.0). cargo-zigbuild filters that argument since 0.23.0 (rust-cross/cargo-zigbuild#451 / #452), so this bumps the pinned version and adapts the installer to the current release archives.Failure on
main(jobtarget (zig,ubuntu-latest), run 35965047836, 2026-09-24, Rust 1.98.1):The same job was green on 2026-08-19 (run 32250555535, Rust 1.97.1); it has been red on both
mainpushes since (runs 35964074174 and 35965047836) and in the weekly runs.Reproduction:
cargo xtask build-docker-image zigfollowed by./ci/test-zig-image.shwith a stable toolchain >= 1.98, exactly as the CI job does. On my fork, the same steps fail at HEAD (run 36208936418) and pass with this change (runs 36208937247 and 36209338211).Changes in
docker/zig.sh:cargo-zigbuild0.17.5 -> 0.23.4.cargo-zigbuild-<triple>.tar.xzand contain acargo-zigbuild-<triple>/directory, so the download URL, thetarflags and the extracted path change accordingly; the repository moved torust-cross/cargo-zigbuild.x86_64(gnu, musl) andaarch64(gnu):linux/amd64keeps the musl build,linux/arm64uses the gnu build (the image is Ubuntu 24.04, so glibc is present), andlinux/386falls through to the existingcargo installpath.Zig stays at 0.11.0; cargo-zigbuild 0.23 still supports it. CI builds the image for
linux/amd64only, which is the path exercised by the fork run above.Disclosure: this change was prepared with an AI coding agent (Claude Code); I reviewed the diff and the fork runs above are the verification.