standardize kind cluster name and drop upjet as dependency - #450
Open
fernandezcuesta wants to merge 5 commits into
Open
fernandezcuesta wants to merge 5 commits into
fernandezcuesta wants to merge 5 commits into
Conversation
…et as dependency Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
changed the title
Collaborator
|
Nice! I have some similar fixes, would be nice to get this out to avoid conflicts. I think in general splitting PRs that touch multiple unrelated things, like the runner OS upgrade, reformatting, splitting them, go upgrade, would make it easier to get out without conflicts? And if we want to reformat " -> ' we should probably fix all in one PR |
Collaborator
Author
|
Yeah it's a wip of some stuff I saw we need to upgrade soonish. The reformat is my vscode extension doing some shenanigans, will revert |
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
force-pushed
the
chore/improve-local-deployment
branch
from
September 8, 2026 12:02
1dd70b0 to
48ddf8c
Compare
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
marked this pull request as ready for review
September 8, 2026 14:26
fernandezcuesta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Keep the default kind cluster name as other providers, so we get the same UX / predictable cluster name.
Also, drop upjet as dependency which we don't use at all.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested