chore: cumulative CI improvements - #454
fernandezcuesta wants to merge 1 commit into
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
changed the title
| description: "Version string to use while publishing the package (e.g. v1.0.0-alpha.1)" | ||
| default: "" | ||
| required: false | ||
| go-version: |
There was a problem hiding this comment.
this input is gone, but the job below still passes go-version: ${{ github.event.inputs.go-version }} — I think that resolves to empty now. publish-provider-non-family.yml has default: '1.22', so the release build either gets an empty version or 1.22, and go.mod needs 1.26.
That workflow doesn't read go.mod either, so we can't decouple this one the same way — should we keep passing it explicitly here, or pin it in the reusable call? Or suggest version file as an option upstream?
| jobs: | ||
| create-tag: | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-26.04 |
There was a problem hiding this comment.
FYI: ubuntu-26.04 is still marked preview https://github.blog/changelog/2026-06-11-new-runner-images-in-public-preview/
There was a problem hiding this comment.
Ok I will change to ubuntu-latest. Puzzled that an LTS which is almost half a year stable is still a preview...
| with: | ||
| repository: provider-sql | ||
| version: ${{ github.event.inputs.version }} | ||
| go-version: ${{ github.event.inputs.go-version }} |
There was a problem hiding this comment.
Oh you're right, I'll fix that
2 participants
Description of your changes
go.moddirectlyI have:
make reviewableto ensure this PR is ready for review.How has this code been tested
n/a
[contribution process]: https://git.io/fj2m9