fix(build): add Windows PE metadata to crowdin.exe - #1092
Draft
andrii-bodnar wants to merge 1 commit into
Draft
Conversation
The released crowdin.exe carried no VERSIONINFO resource at all, so Windows showed no publisher, product name or version in file properties. An unsigned PE with a blank version resource also feeds AV heuristics - 5.0.0 came back 1/68 on the Chocolatey virus scan. Bun's --windows-* flags only work on a Windows host (they depend on Windows APIs), so the exe can no longer be cross-compiled on ubuntu. Build it once in a new win-binary job and reuse that artifact for the npm package, the release asset and the Inno Setup installer. Side benefit: the installer now ships the exact binary the release publishes instead of a separately compiled one. Both Windows jobs assert the metadata is non-empty, so the flags cannot fall out of the build script unnoticed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
andrii-bodnar
marked this pull request as draft
August 28, 2026 07:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 140 140
Lines 11364 11364
=======================================
Hits 10468 10468
Misses 896 896 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The released crowdin.exe carried no VERSIONINFO resource at all, so Windows showed no publisher, product name or version in file properties. An unsigned PE with a blank version resource also feeds AV heuristics - 5.0.0 came back 1/68 on the Chocolatey virus scan.
Bun's --windows-* flags only work on a Windows host (they depend on Windows APIs), so the exe can no longer be cross-compiled on ubuntu. Build it once in a new win-binary job and reuse that artifact for the npm package, the release asset and the Inno Setup installer. Side benefit: the installer now ships the exact binary the release publishes instead of a separately compiled one.
Both Windows jobs assert the metadata is non-empty, so the flags cannot fall out of the build script unnoticed.