Skip to content

Add unit tests - #14

Merged
Zain-Mahmoud merged 3 commits into
mainfrom
Zain-Mahmoud-onboarding
Aug 3, 2026
Merged

Add unit tests#14
Zain-Mahmoud merged 3 commits into
mainfrom
Zain-Mahmoud-onboarding

Conversation

@Zain-Mahmoud

Copy link
Copy Markdown
Contributor

Summary

Added unit tests

Validation

  • scripts/quality-check.sh passes locally
  • Appropriate /test commands were run and are passing (e.g. /test gpu)
  • Unit tests were added / e2e tests were added where applicable
  • Manual testing, if applicable (describe further):

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behaviour changes.
  • No secrets, generated files, or files that only make sense on my machine are included.
  • Relevant documentation is updated.

Additional Comments

The unit test which checks the length of the user_list should be updated from assert len(user_list) == 1 to assert len(user_list) >= 1 as we add our usernames to the list.

@Zain-Mahmoud Zain-Mahmoud linked an issue Aug 3, 2026 that may be closed by this pull request
@Zain-Mahmoud
Zain-Mahmoud requested a review from KurbyDoo August 3, 2026 20:46
KurbyDoo
KurbyDoo previously approved these changes Aug 3, 2026

@KurbyDoo KurbyDoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, generally I'll approve but leave comments for issues to fix unless there is a major issue, then I will block and request changes. Otherwise, as long as you follow up to resolve any additional comments, then the PR looks good to merge

Comment thread tests/test_introduction.py Outdated
@KurbyDoo

KurbyDoo commented Aug 3, 2026

Copy link
Copy Markdown
Member

/test all

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Tests passed

  • Groups run: python, slow, web
  • Commit tested: c41cb33
  • Full log: Actions run
Group Result
python 32/32 passed
slow 0/0 passed
web 1/1 passed

@KurbyDoo KurbyDoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops need to update project settings to not dismiss reviews

@Zain-Mahmoud
Zain-Mahmoud merged commit afc62b3 into main Aug 3, 2026
3 checks passed
@Zain-Mahmoud
Zain-Mahmoud deleted the Zain-Mahmoud-onboarding branch August 3, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zain-Mahmoud - Onboarding

2 participants