Add unit tests - #14
Merged
Merged
Conversation
KurbyDoo
previously approved these changes
Aug 3, 2026
KurbyDoo
left a comment
Member
There was a problem hiding this comment.
LGTM, generally I'll approve but leave comments for issues to fix unless there is a major issue, then I will block and request changes. Otherwise, as long as you follow up to resolve any additional comments, then the PR looks good to merge
Member
|
/test all |
|
Tests passed
|
KurbyDoo
approved these changes
Aug 3, 2026
KurbyDoo
left a comment
Member
There was a problem hiding this comment.
whoops need to update project settings to not dismiss reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added unit tests
Validation
scripts/quality-check.shpasses locally/testcommands were run and are passing (e.g./test gpu)Checklist
Additional Comments
The unit test which checks the length of the
user_listshould be updated fromassert len(user_list) == 1toassert len(user_list) >= 1as we add our usernames to the list.