I completed onboarding - #21
Open
mouftz wants to merge 1 commit into
Open
Conversation
Member
|
/test all |
Member
|
github actions are down, will have to run later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completed the onboarding exercise from issue #:
mouftztouser_listintests/test_introduction.pytest_mouftz(palindrome check on"racecar")test_kurbydoo's length assertion from== 2to== 3to reflect the new list sizeVerified locally with
uv run pytest(33 passed) anduv run ruff check ./uv run ruff format --check .(clean).Validation
scripts/quality-check.shpasses locally/testcommands were run and are passing (e.g./test gpu)Checklist
Additional Comments
Closes #20
scripts/format-check.shfails on macOS's default bash (3.2) at line 49:check_format[@]: unbound variable. It's an unset-array expansion underset -u. Fix is"${check_format[@]:-}". Works fine on Linux and bash 5+