Skip to content

I completed onboarding - #21

Open
mouftz wants to merge 1 commit into
mainfrom
mouftz-onboarding
Open

I completed onboarding#21
mouftz wants to merge 1 commit into
mainfrom
mouftz-onboarding

Conversation

@mouftz

@mouftz mouftz commented Aug 6, 2026

Copy link
Copy Markdown

Summary

Completed the onboarding exercise from issue #:

  • Added mouftz to user_list in tests/test_introduction.py
  • Added test_mouftz (palindrome check on "racecar")
  • Updated test_kurbydoo's length assertion from == 2 to == 3 to reflect the new list size

Verified locally with uv run pytest (33 passed) and uv run ruff check . / uv run ruff format --check . (clean).

Validation

  • scripts/quality-check.sh passes locally
  • Appropriate /test commands were run and are passing (e.g. /test gpu)
  • Unit tests were added / e2e tests were added where applicable
  • Manual testing, if applicable (describe further):

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behaviour changes.
  • No secrets, generated files, or files that only make sense on my machine are included.
  • Relevant documentation is updated.

Additional Comments

Closes #20
scripts/format-check.sh fails on macOS's default bash (3.2) at line 49: check_format[@]: unbound variable. It's an unset-array expansion under set -u. Fix is "${check_format[@]:-}". Works fine on Linux and bash 5+

@mouftz
mouftz requested a review from KurbyDoo August 6, 2026 19:40
@mouftz mouftz self-assigned this Aug 6, 2026

@KurbyDoo KurbyDoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KurbyDoo

KurbyDoo commented Aug 6, 2026

Copy link
Copy Markdown
Member

/test all

@KurbyDoo

KurbyDoo commented Aug 6, 2026

Copy link
Copy Markdown
Member

https://www.githubstatus.com/

github actions are down, will have to run later

@KurbyDoo KurbyDoo closed this Aug 6, 2026
@KurbyDoo KurbyDoo reopened this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mouftz - Onboarding

2 participants