Conversation
FritzHeiden
requested changes
Sep 8, 2026
FritzHeiden
left a comment
FritzHeiden
left a comment
Collaborator
There was a problem hiding this comment.
Please address these findings
Comment on lines
+1351
to
+1354
| currentTime: video.currentTime, | ||
| bufferedRanges: bufferedRanges, | ||
| duration: duration, | ||
| role: _role, |
Collaborator
There was a problem hiding this comment.
This payload is never actually used so we may discard it.
| } | ||
|
|
||
| var trigger = reason || "update"; | ||
| logger.info( |
Collaborator
There was a problem hiding this comment.
Please use debug instead of info
Comment on lines
-98
to
-109
| var bufferedLogs = []; | ||
| var targetToken = token || "local"; | ||
| logger.on("log", function (log) { | ||
| bufferedLogs.push(log); | ||
| var test = "/" + testInfo.path; | ||
| WaveService.sendLogs(targetToken, test, [log]); | ||
| }); | ||
| setInterval(function () { | ||
| if (bufferedLogs.length > 0) { | ||
| var test = "/" + testInfo.path; | ||
| var logs = bufferedLogs.slice(); | ||
| bufferedLogs = []; | ||
| WaveService.sendLogs(token, test, logs); | ||
| } | ||
| }, 3000); |
Collaborator
There was a problem hiding this comment.
Please revert these changes
Comment on lines
+688
to
+694
| if (typeof player.getForwardBufferAtCurrentTime === "function") { | ||
| try { | ||
| forwardBuffer = player.getForwardBufferAtCurrentTime(); | ||
| } catch (error) { | ||
| forwardBuffer = null; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
The getForwardBufferAtCurrentTime function doesn't exist in the player, so this will never succeed. You can remove this entire if-condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.