[bugfix] Fix GetInfoLogFiles using wrong path for log file prefix - #8
Merged
Merged
Conversation
When db_log_dir is set and dbname is a relative path, GetInfoLogFiles incorrectly uses dbname instead of db_absolute_path to build the log file prefix. This causes mismatch with InfoLogFileName which uses db_absolute_path, resulting in failure to identify existing log files during AutoRollLogger restart. Consequently, log files accumulate beyond the keep_log_file_num limit. Root cause: GetInfoLogFiles used dbname for InfoLogPrefix construction while InfoLogFileName uses db_absolute_path. When these differ (e.g., relative dbname vs absolute cwd), the prefixes don't match. Fix: Add db_absolute_path parameter to GetInfoLogFiles and use it for InfoLogPrefix construction, consistent with InfoLogFileName behavior. Changes: - file/filename.h: Add db_absolute_path parameter - file/filename.cc: Use db_absolute_path for InfoLogPrefix - logging/auto_roll_logger.cc: Pass db_absolute_path_ to GetInfoLogFiles - utilities/convenience/info_log_finder.cc: Get and pass db_absolute_path - logging/auto_roll_logger_test.cc: Add test case GetInfoLogFilesPrefixMismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When db_log_dir is set and dbname is a relative path, GetInfoLogFiles incorrectly uses dbname instead of db_absolute_path to build the log file prefix. This causes mismatch with InfoLogFileName which uses db_absolute_path, resulting in failure to identify existing log files during AutoRollLogger restart. Consequently, log files accumulate beyond the keep_log_file_num limit.
Root cause: GetInfoLogFiles used dbname for InfoLogPrefix construction while InfoLogFileName uses db_absolute_path. When these differ (e.g., relative dbname vs absolute cwd), the prefixes don't match.
Fix: Add db_absolute_path parameter to GetInfoLogFiles and use it for InfoLogPrefix construction, consistent with InfoLogFileName behavior.
Changes: