Add a note on how to set the collection to use for vmware inventory - #252
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds documentation to the inventory_source module explaining how to select the VMware inventory plugin/collection used during sync via source_vars.plugin, with an additional example showing how to target vmware.vmware.
Changes:
- Documented the
source_vars.pluginkey for VMware inventory sources (including default vs alternate example FQCNs). - Added an Ansible task example showing
source_vars.plugin: vmware.vmware.vmsfor a VMware inventory source.
File summaries
| File | Description |
|---|---|
| plugins/modules/inventory_source.py | Updates module docs and examples to clarify how to choose the VMware inventory plugin/collection via source_vars. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheWitness
approved these changes
Aug 31, 2026
TheWitness
left a comment
TheWitness
left a comment
There was a problem hiding this comment.
Minor copilot comment on sentence structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.