Skip to content

Fix 2 issues with VMWare SDK and included nspkg.pth files - #17

Merged
cigamit merged 1 commit into
mainfrom
nspkg.pth
Aug 31, 2026
Merged

Fix 2 issues with VMWare SDK and included nspkg.pth files#17
cigamit merged 1 commit into
mainfrom
nspkg.pth

Conversation

@cigamit

@cigamit cigamit commented Aug 31, 2026

Copy link
Copy Markdown

This resolves 2 issues.

  1. The VMWare SDK was failing to load as it still required pkg_resources, which was removed in later versions of setuptools. So we pin to an earlier version until this is resolves
  2. The additional nspkg.pth files that are automatically being added were causing pip to fail to install packages during job runs. So cleaning these up as they are unneeded. Resolves Legacy namespace-package .pth files in ascender-ee break all pip source builds ascender#767

@cigamit
cigamit requested a review from TheWitness August 31, 2026 04:47
@cigamit cigamit self-assigned this Aug 31, 2026
Copilot AI lite review requested due to automatic review settings August 31, 2026 04:47
@cigamit cigamit added the bug Something isn't working label Aug 31, 2026
@ciq-it-service-account

ciq-it-service-account commented Aug 31, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts the execution environment build to address VMware SDK runtime compatibility with newer setuptools and to prevent legacy namespace .pth shims from breaking pip source builds in derived images.

Changes:

  • Pin setuptools<81 to keep pkg_resources available for the vSphere Automation SDK runtime imports.
  • Remove legacy NSX SDK *-nspkg.pth files from site-packages during the final image build to restore pip isolated build behavior.
File summaries
File Description
execution-environment.yml Pins setuptools to preserve VMware SDK compatibility and adds a build-step cleanup of NSX namespace-package .pth shims.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread execution-environment.yml
@cigamit
cigamit merged commit 1eda9ed into main Aug 31, 2026
5 checks passed
@cigamit
cigamit deleted the nspkg.pth branch August 31, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

Legacy namespace-package .pth files in ascender-ee break all pip source builds

4 participants