Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “tkgi” (VMware Tanzu Kubernetes Grid Integrated Edition) install path to the Ascender installer, aligning it with the existing platform-specific Ansible task structure and providing accompanying documentation and example config/inventory.
Changes:
- Introduces TKGI-specific Ansible tasks and Kubernetes manifest templates for cluster validation, Ascender install, and Ledger install.
- Updates installer UX/docs/config to recognize
k8s_platform: tkgi(README, default config comments, interactive config generator). - Improves OS-family detection in
setup.sh, adds Debian keyring dir setup, and adds a Python Kubernetes client presence check/install.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.sh | Expands OS-family detection, updates OS gating messaging, and adds Python kubernetes client install logic. |
| README.md | Documents TKGI as a valid k8s_platform option. |
| playbooks/roles/setup_playbooks/tasks/ascender_credentials_tkgi.yml | Adds TKGI path for waiting on Ascender API readiness via AWX organization existence. |
| playbooks/roles/ledger_install/templates/ledger_deployment_tkgi.yaml | Adds TKGI Ledger Kubernetes manifest template (secrets/services/ingress/deployments). |
| playbooks/roles/ledger_install/tasks/ledger_install_tkgi.yml | Adds TKGI Ledger install workflow using kubeconfig context + kubernetes.core modules + Ledger configuration. |
| playbooks/roles/k8s_setup/tasks/k8s_setup_tkgi.yml | Adds TKGI cluster validation (kubeconfig/context/version/ingress/storage/RBAC) and optional /etc/hosts population. |
| playbooks/roles/common/vars/main.yml | Extends Debian package mapping to include Debian 11 prerequisites. |
| playbooks/roles/common/tasks/main.yml | Ensures /etc/apt/keyrings exists for Debian/Ubuntu setup flows. |
| playbooks/roles/ascender_install/templates/ascender-deployment/ascender-deployment-tkgi.yml | Adds TKGI Ascender AWX CR + secrets template with ingress class/annotations support. |
| playbooks/roles/ascender_install/tasks/ascender_install_tkgi.yml | Adds TKGI Ascender install workflow (operator apply, CR apply, optional Postgres patching). |
| docs/installation/tkgi/tkgi.inventory | Provides example TKGI inventory. |
| docs/installation/tkgi/tkgi.custom.config.yml | Provides example TKGI config values and TKGI-specific knobs. |
| docs/installation/tkgi/README.md | Adds TKGI installation guide and prerequisites. |
| default.config.yml | Updates inline documentation to include tkgi among platform options. |
| config_vars.sh | Adds tkgi to interactive platform selection and related prompts (e.g., /etc/hosts, TLS inputs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for VMware Tanzu Kubernetes Grid Integrated, thanks to an anonymous donor.
Fix a few issues noted elsewhere.