Drop React installation - #203
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the (now non-functional) “Ascender React” / EDA OSS installation path from the installer playbooks, including the playbook entrypoint, role tasks/templates, and related configuration variables.
Changes:
- Drops the
install_react.ymlplaybook and its invocation from the mainsetup.ymlflow. - Removes React/EDA-related
/etc/hostsmanagement tasks for OCP and K3s setups. - Deletes the
ascender_reactrole’s install tasks and Kubernetes manifest templates, and removes all React/EDA variables from shared group vars.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| playbooks/setup.yml | Removes the “Install Ascender React” import so React/EDA is no longer part of the default setup flow. |
| playbooks/roles/k8s_setup/tasks/k8s_setup_ocp.yml | Removes /etc/hosts entry management for REACT_HOSTNAME on OCP. |
| playbooks/roles/k8s_setup/tasks/k8s_setup_k3s.yml | Removes /etc/hosts entry management for REACT_HOSTNAME on K3s. |
| playbooks/roles/ascender_react/templates/react-deployment/react-deployment-k3s.yml | Deletes the K3s React/EDA deployment manifest template. |
| playbooks/roles/ascender_react/templates/react-deployment/react-deployment-gke.yml | Deletes the GKE React/EDA deployment manifest template. |
| playbooks/roles/ascender_react/templates/react-deployment/react-deployment-eks.yml | Deletes the EKS React/EDA deployment manifest template. |
| playbooks/roles/ascender_react/templates/react-deployment/react-deployment-aks.yml | Deletes the AKS React/EDA deployment manifest template. |
| playbooks/roles/ascender_react/templates/eda-operator/kustomization.j2 | Deletes the EDA operator Kustomize template used by the React/EDA install path. |
| playbooks/roles/ascender_react/tasks/react_install_k3s.yml | Deletes the React/EDA install task flow for K3s. |
| playbooks/roles/ascender_react/tasks/react_install_gke.yml | Deletes the React/EDA install task flow for GKE. |
| playbooks/roles/ascender_react/tasks/react_install_eks.yml | Deletes the React/EDA install task flow for EKS. |
| playbooks/roles/ascender_react/tasks/react_install_aks.yml | Deletes the React/EDA install task flow for AKS. |
| playbooks/install_react.yml | Removes the standalone React/EDA installer playbook. |
| playbooks/group_vars/all.yml | Removes all React/EDA-related variables from shared configuration defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was attempting to install the open source version of EDA, but it stopped working a while back. Dropping it for now.