Ensure we are encapsulating all passwords in quotes - #204
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates config_vars.sh to wrap additional password values in quotes when writing custom.config.yml, preventing YAML parsing errors for “complex” passwords containing special characters (per Issue #176).
Changes:
- Quote
ASCENDER_PGSQL_PWDwhen emitted tocustom.config.yml. - Quote
LEDGER_ADMIN_PASSWORDwhen emitted tocustom.config.yml. - Quote
LEDGER_DB_PASSWORDwhen emitted tocustom.config.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were doing it for the Ascender Admin password, just not the others.
Resolves #176