Since Ledger is using the internal IP, it will always be http - #226
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR fixes the Ascender → Ledger (parser) linkage by forcing the log aggregator endpoint scheme to http when targeting the Ledger parser’s internal ClusterIP, avoiding incorrect https URLs derived from k8s_lb_protocol.
Changes:
- Hardcode
LOG_AGGREGATOR_HOSTtohttp://{{ ledger_parser_ip }}for TKGI, RKE2, K3s, GKE, DKP, and AKS installs. - Ensure consistent behavior across Kubernetes distributions where the parser service is a ClusterIP (port 5000).
File summaries
| File | Description |
|---|---|
| playbooks/roles/ledger_install/tasks/ledger_install_tkgi.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
| playbooks/roles/ledger_install/tasks/ledger_install_rke2.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
| playbooks/roles/ledger_install/tasks/ledger_install_k3s.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
| playbooks/roles/ledger_install/tasks/ledger_install_gke.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
| playbooks/roles/ledger_install/tasks/ledger_install_dkp.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
| playbooks/roles/ledger_install/tasks/ledger_install_aks.yml | Force log aggregator host scheme to HTTP for parser ClusterIP. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheWitness
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue where it can't setup the link between Ascender and Ledger