Change to Pinned versions for the control plane / default EE - #20
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates default Execution Environment (EE) image tags so the control plane, mesh ingress, and installer defaults can follow the Ascender version via DEFAULT_AWX_VERSION, instead of always defaulting to :latest.
Changes:
- Updated mesh ingress defaults to derive
_control_plane_ee_imagetag fromDEFAULT_AWX_VERSION. - Updated installer defaults to derive
ee_imagesand_control_plane_ee_imagefromDEFAULT_AWX_VERSION. - Updated the “deploying a specific version” documentation note to reflect the new EE default behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| roles/mesh_ingress/defaults/main.yml | Switches mesh ingress control-plane EE default image tag to follow DEFAULT_AWX_VERSION (fallback latest). |
| roles/installer/defaults/main.yml | Switches default EE registration image and control-plane EE image tag to follow DEFAULT_AWX_VERSION. |
| docs/user-guide/advanced-configuration/deploying-a-specific-version-of-awx.md | Updates documentation note to describe EE defaults tracking DEFAULT_AWX_VERSION. |
Suppressed comments (1)
roles/installer/defaults/main.yml:292
- Deriving init container image/name via split(':')[0]/[1] breaks if the registry contains a port (e.g. my-registry:5000/repo/image:tag), producing an invalid image and version. Split from the right so only the tag is separated from the image reference.
_control_plane_ee_image: "ghcr.io/ctrliq/ascender-ee:{{ lookup('env', 'DEFAULT_AWX_VERSION') or 'latest' }}"
_init_container_image: "{{ _control_plane_ee_image.split(':')[0] }}"
_init_container_image_version: "{{ _control_plane_ee_image.split(':')[1] }}"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (4)
docs/user-guide/advanced-configuration/deploying-a-specific-version-of-awx.md:39
- This note links to a local absolute filesystem path (
/home/weyerkaa/...), which won’t work for docs readers. Also, the phrasing "we are now changing" reads like a transitional statement rather than documenting the current default behavior.
**Note**: The `image` and `image_version` are intended for local mirroring scenarios. `DEFAULT_AWX_VERSION` controls the main Ascender image tag and we are now changing the execution environment default to the same pinned release for `ghcr.io/ctrliq/ascender-ee` unless you override them explicitly. For the current defaults, check [roles/installer/defaults/main.yml](/home/weyerkaa/ascender-operator/roles/installer/defaults/main.yml).
docs/user-guide/advanced-configuration/deploying-a-specific-version-of-awx.md:39
- The defaults table above still states
ee_imagesandcontrol_plane_ee_imagedefault toghcr.io/ctrliq/ascender-ee:latest, which is now inconsistent with the updated pinned defaults described here. Please update the table rows so the documented defaults match the actual defaults.
**Note**: The `image` and `image_version` are intended for local mirroring scenarios. `DEFAULT_AWX_VERSION` controls the main Ascender image tag and we are now changing the execution environment default to the same pinned release for `ghcr.io/ctrliq/ascender-ee` unless you override them explicitly. For the current defaults, check [roles/installer/defaults/main.yml](/home/weyerkaa/ascender-operator/roles/installer/defaults/main.yml).
roles/installer/defaults/main.yml:287
- The default
ee_images[0].namenow includes the version ("Ascender EE ({{ _image_version }})"). Because this name is written intoGLOBAL_JOB_EXECUTION_ENVIRONMENTS, changing it each release can create a new execution environment name on upgrades and potentially break references to the previous default EE in existing job templates.
- name: "Ascender EE ({{ _image_version }})"
image: "ghcr.io/ctrliq/ascender-ee:{{ _image_version }}"
roles/mesh_ingress/defaults/main.yml:12
- This role duplicates the
DEFAULT_AWX_VERSIONlookup inline in_control_plane_ee_image. Defining_image_versiononce (as inroles/installer/defaults/main.yml) makes the default easier to keep consistent and avoids repeating the env lookup in future edits.
_control_plane_ee_image: "ghcr.io/ctrliq/ascender-ee:{{ lookup('env', 'DEFAULT_AWX_VERSION') or 'latest' }}"
This will make it so the control plane, mesh, and default EE uses a version pinned to the version of Ascender.