Fix issue with sliced node names in workflow menu - #774
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Fixes the workflow output navigation menu labeling for “sliced” workflow nodes (e.g., from Federated Inventory) where node identifiers can be blank and job names can be duplicated, ensuring the menu remains usable and navigation remains correct.
Changes:
- Add positional fallback labels (
Workflow Job X/Y) when a workflow node’sidentifieris blank. - Extend the component test suite to cover sliced-node labeling, navigation, and filtering stability.
File summaries
| File | Description |
|---|---|
| awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.js | Adds positional fallback labeling for blank-identifier nodes in the workflow job selector. |
| awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.test.js | Adds test coverage for sliced workflows to validate labeling and navigation behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.js:82
nodeLabel()does ajobNodes.findIndex(...)for blank identifiers, andnodeLabel()is also used inside filtering. For larger workflows this can turn into O(n²) work per render; precomputing positions once per render avoids repeated linear scans.
const nodeLabel = (node) => {
if (stringIsUUID(node.identifier)) {
return node.summary_fields.job.name;
}
if (node.identifier) {
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
TheWitness
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #760 we fixed the workflow menu for normal workflow jobs. This also fixes it for sliced jobs (like from a Federated Inventory).