Skip to content

Fix issue with sliced node names in workflow menu - #774

Merged
cigamit merged 3 commits into
mainfrom
sliced_workflow_menu
Aug 31, 2026
Merged

Fix issue with sliced node names in workflow menu#774
cigamit merged 3 commits into
mainfrom
sliced_workflow_menu

Conversation

@cigamit

@cigamit cigamit commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

In #760 we fixed the workflow menu for normal workflow jobs. This also fixes it for sliced jobs (like from a Federated Inventory).

@cigamit
cigamit requested a review from TheWitness August 31, 2026 14:33
@cigamit cigamit self-assigned this Aug 31, 2026
Copilot AI lite review requested due to automatic review settings August 31, 2026 14:33
@cigamit cigamit added bug Something isn't working javascript Pull requests that update javascript code labels Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Pull request overview

Fixes the workflow output navigation menu labeling for “sliced” workflow nodes (e.g., from Federated Inventory) where node identifiers can be blank and job names can be duplicated, ensuring the menu remains usable and navigation remains correct.

Changes:

  • Add positional fallback labels (Workflow Job X/Y) when a workflow node’s identifier is blank.
  • Extend the component test suite to cover sliced-node labeling, navigation, and filtering stability.
File summaries
File Description
awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.js Adds positional fallback labeling for blank-identifier nodes in the workflow job selector.
awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.test.js Adds test coverage for sliced workflows to validate labeling and navigation behavior.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 31, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings August 31, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

awx/ui/src/components/WorkflowOutputNavigation/WorkflowOutputNavigation.js:82

  • nodeLabel() does a jobNodes.findIndex(...) for blank identifiers, and nodeLabel() is also used inside filtering. For larger workflows this can turn into O(n²) work per render; precomputing positions once per render avoids repeated linear scans.
  const nodeLabel = (node) => {
    if (stringIsUUID(node.identifier)) {
      return node.summary_fields.job.name;
    }
    if (node.identifier) {
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread awx/ui/src/screens/Job/Job.js
@cigamit
cigamit merged commit 6c3237e into main Aug 31, 2026
10 checks passed
@cigamit
cigamit deleted the sliced_workflow_menu branch August 31, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update javascript code

Development

Successfully merging this pull request may close these issues.

3 participants