el8 grub2: Release 167.1.5%{?dist} (grub2-pc-modules fix never actually shipped) - #10
Merged
Conversation
.0.1.4's changelog entry claims the with_legacy_modules fix (grub2-pc-modules on x86_64), but that fix was edited into the spec in place under the same release number after .0.1.4 had already been published. Real repos and our own reference build both confirm grub2-pc-modules is missing from .0.1.4. Republishing under the same NVR isn't safe, so this is a release bump only -- no other changes; the with_legacy_modules fix itself was already correct. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR performs an EL8 CIQ grub2 release bump to ensure the previously intended with_legacy_modules / grub2-pc-modules fix is actually shipped under a new, safe NVR (avoiding republishing the already-published .0.1.4).
Changes:
- Bump
Releasefrom167%{?dist}.ciq.0.1.4to167%{?dist}.ciq.0.1.5. - Add a new
%changelogentry documenting that this is a rebuild/release bump only.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juphoff
self-requested a review
July 31, 2026 20:05
juphoff
previously approved these changes
Jul 31, 2026
Per releng: %{?dist} belongs at the end of Release (standard convention,
most tooling assumes dist is the last component), and the .ciq marker is
redundant. Same NVR content/fix as the previous commit, just reformatted:
grub2-2.02-167.1.5.el8 instead of grub2-2.02-167.el8.ciq.0.1.5.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jason-rodri
changed the title
juphoff
approved these changes
Jul 31, 2026
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #9, which conflicts with
ciq8becauseadd-ciq-grub2-provides-ciq8was already merged once before (PR #5) and its older commits now exist on
ciq8under different SHAs from a squash/rebase-merge — same class ofconflict already hit and solved once for
ciq9(#7 → #8).This branch is fresh off
ciq8's current tip with only the genuinely newcommits on top.
The underlying fix:
.0.1.4's changelog entry claims thewith_legacy_modulesfix (grub2-pc-modulesbuilt on x86_64), but that fixwas edited into the spec after
.0.1.4was already published, under thesame release number. Both the real published packages and our own reference
build are missing
grub2-pc-modulesat.0.1.4despite the spec beingcorrect. Republishing under the same NVR isn't safe, so this bumps the
release.
Release format (per releng review):
%{?dist}moved to the end ofRelease(standard convention — most tooling assumes dist is the lastcomponent), and the redundant
.ciqmarker dropped. Final NVR:grub2-2.02-167.1.5.el8, Epoch 5.Test plan
rpmspec -q --target x86_64confirmsgrub2-pc-modules,grub2-efi-x64-modules,grub2-efi-ia32-modulesare declaredrpm -qpon the rebuilt SRPM confirms NVRgrub2-2.02-167.1.5.el8, Epoch 5sb_build.sh <variant> el8-grub2and confirmgrub2-pc-modulesactually appears in the signed output (x86_64 only — aarch64 never builds
grub2-pc)dnf updatetest on an EL8.6/RLC8/SCN8 box with stockgrub2-pcinstalled, confirming it no longer errors on protected-package removal
🤖 Generated with Claude Code