Added created_by field to users (D1178) - #647
Open
pwlodarski-ctrlo wants to merge 4 commits into
Open
Conversation
droberts-ctrlo
left a comment
droberts-ctrlo
left a comment
Contributor
There was a problem hiding this comment.
Nothing major - just a couple of (very) minor comments
| site_id => $site->id, | ||
| username => $initial_username, | ||
| email => $initial_username, | ||
| site_id => $site->id, |
Contributor
There was a problem hiding this comment.
This should be set automatically - this is in /lib/GADS/Schema.pm
Author
There was a problem hiding this comment.
The site_id was already part of the script before these changes - only the indenting was updated on that line.
| __PACKAGE__->load_namespaces; | ||
|
|
||
| our $VERSION = 111; | ||
| our $VERSION = 112; |
Contributor
There was a problem hiding this comment.
This will need updating to 113 if it is merged after calc datetime (sorry)
Author
There was a problem hiding this comment.
Ouch. After that PR is merged, I'll merge the changes into this branch and upgrade the schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user is created or an account request is approved, the creator/approver's username is set as the
created_byvalue within the user's record. This is likewise reflected in the appropriate audit log messages.