Fix group and aggregate selections (#1639) - #649
Conversation
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - I believe it appears fine. There are many for loops involved, especially nested ones, so I'm slightly concerned about efficiency/performance. I'm assuming there's no other way?
| if $parent; | ||
| # It's optional to supply an aggregate operator, in which case the one | ||
| # configured in the stored field is used. | ||
| if (!$operator) |
There was a problem hiding this comment.
Thanks Pawel, TMTOWTDI... Personally I prefer to only use unless when it is after a statement - I find that quite readable, whereas I find it less natural in a statement such as the one this comment is related to (i.e, if x then do this, vs. do this unless y). As to other opinions, Damian Conway's Perl Best Practices stipulates never to use unless, and unsurprisingly there is even a SO discussion about it: https://stackoverflow.com/questions/3048726/usage-of-if-versus-unless-for-perl-conditionals
There was a problem hiding this comment.
Thank you for clarifying! It does appear to be a heavily discussed topic within the community indeed.
There was a problem hiding this comment.
Probably similar to the discussion of tabs vs spaces, although it is a mystery to me why anyone uses tabs!
2 participants
No description provided.