dev-bootstrap rebase from dev - #654
Open
droberts-ctrlo wants to merge 141 commits into
Open
Conversation
* Formatted test and config code and updated test files Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build. * Update autosave.test.ts * Updated filter where typeahead is missed * Update component.js * Reset erroneous changes * Removed invalid import where required * Update package.json * Updated error handler Updated error handler * Updated ts-ignore where this was causing issues with linting and checking correctness * Updated layoutbuilder to ensure cypress tests pass
* Formatted test and config code and updated test files Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build. * Updated filter where typeahead is missed * Update component.js * Reset erroneous changes * Updated error handler * Formatted test and config code and updated test files Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build. * Added editorconfig and upgraded ESLint to current version * Formatted and changed code with ESLint fixes - functionality has not changed Removed cjs from eslint - cjs are used for internal development files, and should never be included * Fixed formatting and code where this was broken on merge with current dev branch Updated files where dev changes weren't included
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
Updated error handler
…changed Removed cjs from eslint - cjs are used for internal development files, and should never be included
Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
Further package changes and TSConfig updates Removed knip
Updated code files with changes as required where they were included in dev
Updated file where missing function wasn't included
Also removed extra yarn commands that weren't needed, and automated download of browserslist updates on build.
…changed Removed cjs from eslint - cjs are used for internal development files, and should never be included
… dev branch Updated files where dev changes weren't included
Updated documentation Fixed formatting and code where this was broken on merge with current dev branch Added fix for error on documentComponent Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included
Updated code files with changes as required where they were included in dev
Updated to use new switch component for fullscreen
… dev branch Updated and removed extra dependencies and exports where not required Further package changes and TSConfig updates Removed knip Removed extra unused dependencies Updated with changes within current dev Updated code files with changes as required where they were included in dev Updated file where missing function wasn't included Fixed error in markdown that was missed during upgrade
Also update assertions in test to ensure correct calls are being made
Just use specific icons where possible - icons taken from bootstrap icons as available online
Contributor
Author
|
I (genuinely) cannot say why there are multiple commits with different hashes but the same descriptions at different points throughout this code - it is currently up to date, and it is believed that this will be the final version for release (pending review). |
Don't know why I felt that JS/TS should only use single quotes, and it just adds more changes to the tree for what seems like an arbitrary reason. So moving back to double quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap 5 branch ready for merge
Full list of changes:
[JT]SX?files to aid in development and readabilityThis is by no means an exhaustive list