chore: spec §11 polling permanent; remove @hono/node-ws - #52
Merged
Conversation
The 2026-05-17 quality review considered closing spec §11's WebSocket promise by adding SSE browser delivery. Cost/benefit didn't justify ~300-500 lines of new code + reconnect/heartbeat complexity to shave 1.5-3s lag off one screen on a local 127.0.0.1 server. Decision recorded in spec §11: polling stays as the permanent UX delivery mechanism. The architecture summary's "HTTP+WebSocket API" line is updated to "HTTP API". Plan dep list is updated to match. Removes @hono/node-ws from engine runtime deps (was preserved through M9 and N1 PRs awaiting this decision; never imported by any code). EventBus stays — it's engine-internal coordination (scheduler ↔ throttle), not browser delivery. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the F1 (#35) Item 2 follow-up. The 2026-05-17 quality-review WS-delivery primer recommended SSE; on reflection the cost (~300-500 lines + reconnect/heartbeat complexity for a 1.5-3s UX lag improvement on one screen of a local 127.0.0.1 app) didn't justify the work.
@hono/node-wsremoved from engine runtime deps (preserved through M9 + N1 awaiting this decision; never imported)EventBusstays — engine-internal coordination onlyTest plan
@hono/node-wsgone from lockfile🤖 Generated with Claude Code