refactor: renames SilentPaymentAddress - #155
Open
Sosthene00 wants to merge 2 commits into
Open
Conversation
cygnet3
reviewed
Aug 19, 2026
| #[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)] | ||
| pub struct SilentPaymentAddressDisplay { | ||
| sp_address: SilentPaymentAddress, | ||
| pub struct SilentPaymentKeyCode { |
Collaborator
Author
There was a problem hiding this comment.
Yeah sorry I messed the grep up. But actually on closer inspection it was worse than that, a lot of places were still refering to address, either in variable names, methods etc. Docs was unconsistent. Some places now were returning or expecting KeyMaterial while Code would have made more sense, or the contrary. I tried to make everything consistent again.
`SilentPaymentAddress` -> `SilentPaymentKeyMaterial` `SilentPaymentAddressDisplay` -> `SilentPaymentCode`
Rename receive/change APIs, errors, and local names from address/display to code and key material. Drop redundant conversion methods in favor of `From`, and match `SilentPaymentCode::new` argument order to key material.
Sosthene00
force-pushed
the
refactor/rename_sp_code
branch
from
August 20, 2026 11:28
bd6b018 to
7a0873f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SilentPaymentAddress->SilentPaymentKeyMaterialSilentPaymentAddressDisplay->SilentPaymentCode