Skip to content

go-pathrs: don't derive ProcBase from the C enum #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinpitt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

go-pathrs: don't derive ProcBase from the C enum #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion go-pathrs/internal/libpathrs/libpathrs_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,15 @@ func InRootHardlink(oldRootFd uintptr, oldPath string, newRootFd uintptr, newPat
}

// ProcBase is pathrs_proc_base_t (uint64_t).
type ProcBase C.pathrs_proc_base_t
//
// Spelled out rather than taken from C.pathrs_proc_base_t, because cbindgen
// since v0.29.3 emits the C23 fixed-type enum syntax for pathrs_proc_base_t,
// and in C23 mode that makes the typedef name the enum rather than uint64_t.
// CGo maps a C enum to a *signed* Go type, so none of the constants below fit
// in it and the package stops compiling. Every compiler defaulting to C23
// (gcc >= 15) is affected. The values are converted back at each call site
// anyway, so nothing else has to know which spelling the header uses.
type ProcBase uint64

// FIXME: We need to open-code the constants because CGo unfortunately will
// implicitly convert any non-literal constants (i.e. those resolved using gcc)
Expand Down
Loading