The writer lock's TTL outlasts a real borrow - #263
Merged
Conversation
TTL-only was the settled design when the renewal apparatus was cut, but the 60-second value from that renew-pair era rode along. A persist borrow runs for minutes (export alone allows five); the lock now lives three hours, past the browser container's own 150-minute lease. The login-window comment stops claiming a writer lock the window deliberately does not take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTL-only is the lock's settled design: no renewal, one expiry that covers the whole borrow. The 60-second value predates that settlement — it was the short half of a renew-every-20s pair whose renewal machinery was cut, and a persist borrow runs for minutes (the export step alone allows five), so a live borrow could silently lose its lock. The TTL is now three hours, past the browser container's 150-minute lease, so an orphaned lock still clears on its own.
The login-window comment claimed the window holds the session's writer lock; the window deliberately takes no lock, and the comment now describes what actually bounds it: its Redis record and the container lease.
🤖 Generated with Claude Code