Skip to content

DAOS-19102 test: Stabilize NLT memcheck testing of Go binaries (#18454)#18552

Draft
mjmac wants to merge 2 commits into
release/2.8from
mjmac/DAOS-19102-2.8
Draft

DAOS-19102 test: Stabilize NLT memcheck testing of Go binaries (#18454)#18552
mjmac wants to merge 2 commits into
release/2.8from
mjmac/DAOS-19102-2.8

Conversation

@mjmac

@mjmac mjmac commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Go 1.25+ includes a new valgrind build tag which instruments the
Go runtime in a way that valgrind can comprehend. Instead of
fighting a constantly losing battle with valgrind, let's work
with it and ditch the unstable suppressions that need to be updated
for every release of the Go toolchain.

This commit introduces scons and Jenkinsfile changes to enable this
build mode for NLT, but keeps the -race build for normal non-release
testing. Also pulls in a change made on master (DAOS-18797) to
make debuggers/memcheck work better on non-release builds.

Additionally:
By default, NLT runs each test once. Add a --repeat N flag to
allow for multiple iterations to really soak a change. Add a
--failfast flag to allow the loop to be broken if any iteration
fails; otherwise the loop will keep going until the requested
number of loops has completed.

New test pragmas:

  • NLT-repeat: N
  • NLT-repeat-failfast: true

Signed-off-by: Michael MacDonald github@macdonald.cx

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Ticket title is 'Make Go suppressions stable across toolchain versions'
Status is 'In Review'
Labels: 'request_for_2.8.1'
https://daosio.atlassian.net/browse/DAOS-19102

@daosbuild3

Copy link
Copy Markdown
Collaborator

@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch from 78b24e1 to 9a174a9 Compare July 1, 2026 15:23
@daosbuild3

Copy link
Copy Markdown
Collaborator

@daosbuild3

Copy link
Copy Markdown
Collaborator

@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch from 9a174a9 to 76964cc Compare July 4, 2026 14:07
@daosbuild3

Copy link
Copy Markdown
Collaborator

@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch from 76964cc to d63565d Compare July 6, 2026 00:50
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18552/3/execution/node/1586/log

@daosbuild3

Copy link
Copy Markdown
Collaborator

@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch 2 times, most recently from 83db9e5 to 1d57bc1 Compare July 7, 2026 16:48
@daosbuild3

Copy link
Copy Markdown
Collaborator

@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch from 1d57bc1 to e67ce2a Compare July 15, 2026 01:54
mjmac added 2 commits July 17, 2026 10:55
Go 1.25+ includes a new valgrind build tag which instruments the
Go runtime in a way that valgrind can comprehend. Instead of
fighting a constantly losing battle with valgrind, let's work
with it and ditch the unstable suppressions that need to be updated
for every release of the Go toolchain.

This commit introduces scons and Jenkinsfile changes to enable this
build mode for NLT, but keeps the -race build for normal non-release
testing. Also pulls in a change made on master (DAOS-18797) to
make debuggers/memcheck work better on non-release builds.

Additionally:
By default, NLT runs each test once. Add a --repeat N flag to
allow for multiple iterations to really soak a change. Add a
--failfast flag to allow the loop to be broken if any iteration
fails; otherwise the loop will keep going until the requested
number of loops has completed.

New test pragmas:
  * NLT-repeat: N
  * NLT-repeat-failfast: true

Signed-off-by: Michael MacDonald <github@macdonald.cx>
Signed-off-by: Michael MacDonald <github@macdonald.cx>
@mjmac
mjmac force-pushed the mjmac/DAOS-19102-2.8 branch from e67ce2a to 193d38e Compare July 17, 2026 14:55
@daosbuild3

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants