fix(waku): read the renamed unstable_setAllEnv adapter property - #1
Merged
cooper (czxtm) merged 1 commit intoAug 17, 2026
Merged
Conversation
waku 1.0.0-beta.9 renamed the property passed to the createServerEntryAdapter
callback from `setAllEnv` to `unstable_setAllEnv` — the name waku documents in
docs/guides/adapter-authoring.mdx under "Platform Environment Bindings".
Destructuring only the old name leaves it undefined on beta.9, and the call in
defaultExport.fetch then throws inside the deployed Worker:
workerd: Uncaught exception: TypeError: setAllEnv is not a function
The deploy succeeds and every request returns 500 (Cloudflare error 1101), so a
green pipeline ships a dead site.
Aliasing on destructure keeps the call site unchanged. The catalog moves to
beta.9 so the peer range and the property name agree.
Verified against a real Cloudflare deploy of a Waku app: GET / went from 500 to
200 with server-rendered HTML; dynamic routes and public assets recovered too.
cooper (czxtm)
merged commit Aug 17, 2026
295c9b3
into
upstream-main-2026-08-13
1 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waku 1.0.0-beta.9 renamed the property passed to the
createServerEntryAdaptercallback:unstable_setAllEnvis the name waku documents indocs/guides/adapter-authoring.mdxunder Platform Environment Bindings. Aliasing on destructure leaves the call site indefaultExport.fetchuntouched.The catalog moves to beta.9 in the same commit so the peer range and the property name agree.
Why this is worth catching
Destructuring only the old name yields
undefinedon beta.9, and the call throws inside the deployed Worker:Every layer before that is green:
bun installwaku buildalchemy deploySo a passing pipeline ships a dead site, and the exact peer pin (
"waku": "1.0.0-beta.7") is the only thing standing between a consumer and that outcome.Verification
Against a real Cloudflare deploy of a Waku app on waku 1.0.0-beta.9, before → after:
Browser-checked as well: the app renders and the console is clean.
Notes for review
setAllEnv(env)further down is unchanged.unstable_setAllEnv ?? setAllEnv) would support beta.7 and beta.9 from one build, but it does not typecheck while the catalog still pins beta.7, since waku's types only declare one name per version. Bumping the catalog is the cleaner fix; happy to switch if supporting both is preferred.alchemy-run/alchemy@8c458c8rather than this fork'smain, which is ~398 commits behind and predates thecloudflare-frameworks→frontend-frameworksrename, so the file does not exist there. Base branchupstream-main-2026-08-13was pushed for that reason and the diff is the two files below.