Skip to content

New SQL table for tracking neat_periodic_task statuses (mirror-only for now). - #9534

Open
isoos wants to merge 2 commits into
dart-lang:masterfrom
isoos:neat-task-status
Open

New SQL table for tracking neat_periodic_task statuses (mirror-only for now).#9534
isoos wants to merge 2 commits into
dart-lang:masterfrom
isoos:neat-task-status

Conversation

@isoos

@isoos isoos commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@isoos
isoos requested review from jonasfj and sigurdm August 14, 2026 14:45
@jonasfj

jonasfj commented Aug 14, 2026 via email

Copy link
Copy Markdown
Member

@isoos

isoos commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Sure, we could do this in a single migration too, though, some non-runtimeVersioned jobs are a bit heavy.

As an alternative (which could also work for global lock) we could just start using the SQL as the authoritive source, and write the status/lock back to Datastore without considering the status there. The old process may correctly assume that something is running it (for most of the time).

I'll update the PR to do that migration and mirror the state to Datastore.

@jonasfj

jonasfj commented Aug 14, 2026 via email

Copy link
Copy Markdown
Member

@isoos

isoos commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

What jobs are problematic to run twice as often as we do?
It's more concerning if racing is a problem...

The tarball- and the datastore- integrity (both weekly) checks are the most heavy, not sure about the synchronizing exported API (daily) task.

@isoos

isoos commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

PTAL: updated the PR with the version where SQL is the primary store and Datastore is updated so that old runtimeVersion would not try to run the task concurrently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants