Include GitHub Actions repository, commit, and run links in publish emails - #9558
Open
kevmoo wants to merge 5 commits into
Open
Include GitHub Actions repository, commit, and run links in publish emails#9558kevmoo wants to merge 5 commits into
kevmoo wants to merge 5 commits into
Conversation
…mails When packages are published via automated GitHub Actions OIDC authentication, include actionable repository, commit, and workflow run links in maintainer notification emails. * Add Uri-based GitHub URL helpers (githubRepositoryUrl, githubCommitUrl, githubWorkflowRunUrl) in app/lib/shared/urls.dart. * Update createPackageUploadedEmail to format GitHub Actions repository, commit, and run details in both plain text and HTML emails. * Pass GitHub Actions metadata from agent.payload in PackageBackend._performTarballUpload. * Link commit revision hash in audit log summaries. * Add and update unit test coverage across affected components.
…andling * Extract ghPayload in PackageBackend._performTarballUpload to avoid repeating type checks. * Promote local variables commitSha and runId in createPackageUploadedEmail to eliminate force unwraps. * Add unit test coverage for package upload notifications without commit sha.
kevmoo
marked this pull request as ready for review
August 28, 2026 20:21
Member
Author
we can do better than this! |
* Add githubRefUrl and githubUserUrl helper functions in app/lib/shared/urls.dart. * Update createPackageUploadedEmail in app/lib/service/email/email_templates.dart to format the git tag/branch and triggering actor. * Pass githubRef, githubRefType, and githubActor in PackageBackend._performTarballUpload. * Add and update unit tests in urls_test.dart, email_templates_test.dart, and upload_test.dart.
Contributor
|
Nice! Thank you! Added a commit incorporating the git ref/tag and triggering actor into the email metadata as well. |
Member
Author
|
Will hold off until we have a +2 - @jonasfj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packages are published via automated GitHub Actions OIDC authentication, include actionable repository, git ref/tag, commit, workflow run, and actor links in maintainer notification emails.