Skip to content

feat: transfer a DPNS username to another identity #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 6 commits into from
Sep 1, 2026
Merged

feat: transfer a DPNS username to another identity #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
630f29a
feat: transfer a DPNS username to another identity
PastaPastaPasta Sep 1, 2026
ca179bc
refactor: address review of username transfer flow
PastaPastaPasta Sep 1, 2026
4eff65c
refactor: make validateIdentityId delegate to the shared predicate
PastaPastaPasta Sep 1, 2026
c9d1790
fix: make the transfer recipient field usable, validate IDs locally
PastaPastaPasta Sep 1, 2026
3b3b840
test: keep the live transfer spec from provisioning or logging secrets
PastaPastaPasta Sep 1, 2026
2de4e94
fix: treat an emptied recipient field as a change, not a no-op
PastaPastaPasta Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion e2e/deterministic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
E2E_MOCK_MANAGE_WIF,
E2E_MOCK_WITHDRAW_WIF,
E2E_MOCK_WITHDRAW_ADDRESS,
E2E_MOCK_XFER_MNEMONIC,
E2E_MOCK_XFER_RECIPIENT_ID,
} from '../src/e2e-mock-constants';

const MOCK_QUERY = '/?network=testnet&e2e=mock';
Expand Down Expand Up @@ -72,6 +74,9 @@
await page.goto(MOCK_QUERY);

await page.click('#mode-manage-btn');
await expect(page.locator('#manage-action-keys-btn')).toBeVisible();

await page.click('#manage-action-keys-btn');
await expect(page.locator('#manage-identity-id-input')).toBeVisible();

await page.fill('#manage-identity-id-input', E2E_MOCK_IDENTITY_ID);
Expand Down Expand Up @@ -103,7 +108,7 @@
// Invalid identity ID is rejected
await page.fill('#withdraw-identity-id-input', 'nope');
await page.locator('#withdraw-identity-id-input').press('Tab');
await expect(page.getByText('Invalid identity ID format')).toBeVisible();
await expect(page.getByText(/Invalid identity ID/)).toBeVisible();

// Valid identity advances to configure with the balance shown
await page.fill('#withdraw-identity-id-input', E2E_MOCK_IDENTITY_ID);
Expand All @@ -127,7 +132,7 @@

await page.fill('#withdraw-address-input', E2E_MOCK_WITHDRAW_ADDRESS);
await page.locator('#withdraw-address-input').press('Tab');
await expect(page.locator('#withdraw-address-error')).toHaveCount(0);

Check failure on line 135 in e2e/deterministic.spec.ts

View workflow job for this annotation

GitHub Actions / e2e

[chromium] › e2e/deterministic.spec.ts:102:3 › Deterministic UI E2E (mock mode) › withdraw flow validates inputs and completes with status tracking 

  1) [chromium] › e2e/deterministic.spec.ts:102:3 › Deterministic UI E2E (mock mode) › withdraw flow validates inputs and completes with status tracking 
    Error: Timed out 5000ms waiting for expect(locator).toHaveCount(expected)

    Locator: locator('#withdraw-address-error')
    Expected: 0
    Received: 1
    Call log:
      - expect.toHaveCount with timeout 5000ms
      - waiting for locator('#withdraw-address-error')
        9 × locator resolved to 1 element
          - unexpected value "1"


      133 |     await page.fill('#withdraw-address-input', E2E_MOCK_WITHDRAW_ADDRESS);
      134 |     await page.locator('#withdraw-address-input').press('Tab');
    > 135 |     await expect(page.locator('#withdraw-address-error')).toHaveCount(0);
          |                                                           ^
      136 |
      137 |     // Amount below the minimum, above the balance, then valid
      138 |     await page.fill('#withdraw-amount-input', '0.000001');
        at /home/runner/work/dash-bridge/dash-bridge/e2e/deterministic.spec.ts:135:59

// Amount below the minimum, above the balance, then valid
await page.fill('#withdraw-amount-input', '0.000001');
Expand Down Expand Up @@ -182,4 +187,55 @@
await page.click('#register-dpns-btn');
await expect(page.getByText('Registration Complete!')).toBeVisible();
});

test('username transfer flow discovers the identity from a seed phrase and completes', async ({ page }) => {
await page.goto(MOCK_QUERY);

await page.click('#mode-manage-btn');
await page.click('#manage-action-transfer-btn');
await expect(page.locator('#xfer-mnemonic-input')).toBeVisible();

// A phrase that fails the BIP39 checksum is rejected before any lookup.
await page.fill('#xfer-mnemonic-input', 'abandon abandon abandon');
await page.click('#xfer-unlock-btn');
await expect(page.getByText('That is not a valid BIP39 seed phrase.')).toBeVisible();

await page.fill('#xfer-mnemonic-input', E2E_MOCK_XFER_MNEMONIC);
await page.click('#xfer-unlock-btn');

await expect(page.getByText('Signing with key #1 (HIGH level)')).toBeVisible();
await expect(page.locator('.xfer-username-option')).toHaveCount(2);
await expect(page.locator('#xfer-select-continue-btn')).toBeDisabled();

await page.locator('.xfer-username-radio').first().click({ force: true });

// A malformed destination is rejected without a network round trip.
await page.fill('#xfer-recipient-input', 'not-an-identity');
await page.locator('#xfer-recipient-input').blur();
await expect(page.getByText(/Invalid identity ID/)).toBeVisible();

// Transferring to yourself is a no-op the SDK would reject anyway.
await page.fill('#xfer-recipient-input', E2E_MOCK_IDENTITY_ID);
await page.locator('#xfer-recipient-input').blur();
await expect(page.getByText('This is the identity that already owns the username')).toBeVisible();
await expect(page.locator('#xfer-select-continue-btn')).toBeDisabled();

await page.fill('#xfer-recipient-input', E2E_MOCK_XFER_RECIPIENT_ID);
await page.locator('#xfer-recipient-input').blur();
await expect(page.getByText('Destination identity found')).toBeVisible();
await expect(page.locator('#xfer-select-continue-btn')).toBeEnabled();

await page.click('#xfer-select-continue-btn');
await expect(page.getByText('Confirm Transfer')).toBeVisible();
await expect(page.locator('#xfer-transfer-btn')).toBeDisabled();

await page.locator('#xfer-confirm-checkbox').click({ force: true });
await expect(page.locator('#xfer-transfer-btn')).toBeEnabled();

await page.click('#xfer-transfer-btn');
await expect(page.getByText('Username Transferred!')).toBeVisible();
await expect(
page.locator('.contract-id-section', { hasText: 'New Owner' }).locator('.identity-id')
).toHaveText(E2E_MOCK_XFER_RECIPIENT_ID);
});
});
128 changes: 128 additions & 0 deletions e2e/live.transfer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
import { expect, test } from '@playwright/test';

/**
* Live testnet exercise of the username transfer flow.
*
* Opt in with PW_LIVE_XFER=1. These tests broadcast real testnet state
* transitions and spend testnet credits, so they are skipped by default and are
* not part of `npm run test:e2e`.
*
* Each stage opts in separately so that enabling the suite never provisions or
* spends anything on its own:
* PW_XFER_PROVISION=1 create a destination identity
* PW_XFER_TOPUP=<identityId> add credits to an identity
* PW_XFER_SEED / _RECIPIENT / _USERNAME the transfer itself
*/
const LIVE = process.env.PW_LIVE_XFER === '1';
const LIVE_URL = '/?network=testnet';

test.describe('Live testnet username transfer', () => {
test.skip(!LIVE, 'set PW_LIVE_XFER=1 to run');
Comment thread
coderabbitai[bot] marked this conversation as resolved.

test('create a destination identity via the faucet', async ({ page }) => {
test.setTimeout(15 * 60_000);
// Opt in separately: this spends faucet funds, so enabling the suite alone
// must not provision anything.
test.skip(process.env.PW_XFER_PROVISION !== '1', 'set PW_XFER_PROVISION=1 to run');

await page.goto(LIVE_URL);
await page.click('#mode-create-btn');
await page.click('#continue-btn');

await expect(page.locator('.deposit-headline')).toBeVisible({ timeout: 60_000 });

const depositAddress = await page.locator('.deposit-address, .address-value, code').first().innerText();
console.log('DEPOSIT ADDRESS:', depositAddress.trim());

await page.click('#request-faucet-btn');

// Faucet solves a proof-of-work challenge, then the deposit must confirm
// and the identity register — all of which is slow on a live network.
await expect(page.getByText('Save your keys')).toBeVisible({ timeout: 13 * 60_000 });

const identityId = await page
.locator('.contract-id-section', { hasText: 'Your Identity ID' })
.locator('.identity-id')
.innerText();
// The recovery phrase is deliberately NOT logged — runner logs are not a
// place for seed phrases, even testnet ones. Read it off the completion
// screen by hand if you want a reusable destination identity.
console.log('DESTINATION IDENTITY:', identityId.trim());
expect(identityId.trim().length).toBeGreaterThan(40);
});

test('top up the source identity via the faucet', async ({ page }) => {
test.setTimeout(15 * 60_000);
const identityId = process.env.PW_XFER_TOPUP;
test.skip(!identityId, 'set PW_XFER_TOPUP=<identityId> to run');

await page.goto(LIVE_URL);
await page.click('#mode-topup-btn');
await page.fill('#identity-id-input', identityId!);
await page.click('#continue-topup-btn');

await expect(page.locator('.deposit-headline')).toBeVisible({ timeout: 60_000 });
await page.click('#request-faucet-btn');

await expect(page.getByText('Top-up complete!')).toBeVisible({ timeout: 13 * 60_000 });
console.log('TOPPED UP:', identityId);
});

test('transfer a username to the destination identity', async ({ page }) => {
test.setTimeout(10 * 60_000);

const seed = process.env.PW_XFER_SEED;
const recipient = process.env.PW_XFER_RECIPIENT;
const username = process.env.PW_XFER_USERNAME;
test.skip(!seed || !recipient || !username, 'needs PW_XFER_SEED / _RECIPIENT / _USERNAME');

page.on('console', (m) => console.log(`[browser:${m.type()}]`, m.text()));

await page.goto(LIVE_URL);
await page.click('#mode-manage-btn');
await page.click('#manage-action-transfer-btn');

// Seed phrase alone must be enough to find the identity and its signing key.
await page.fill('#xfer-mnemonic-input', seed!);
await page.click('#xfer-unlock-btn');

await expect(page.locator('.xfer-username-list')).toBeVisible({ timeout: 3 * 60_000 });
const signingKey = await page.locator('.key-status.success').innerText();
console.log('SIGNING KEY:', signingKey);
// Must skip the MASTER key at index 0 and pick an eligible one.
expect(signingKey).toMatch(/HIGH|CRITICAL/);

const owned = await page.locator('.xfer-username-label').allInnerTexts();
console.log('OWNED USERNAMES:', owned.join(', '));
expect(owned).toContain(username!);

await page
.locator('.xfer-username-option', { hasText: username! })
.locator('.xfer-username-radio')
.click({ force: true });

// A well-formed but nonexistent recipient must be refused before anything
// is signed. (Not a string of "1"s — that decodes to 44 zero bytes and is
// rejected as malformed by the local check, which is a different path.)
const bogus = 'cEtJ6iEvm51o1zW56pKpytoE8bx8M1Z5bHNR3wBfwae';
await page.fill('#xfer-recipient-input', bogus);
await page.locator('#xfer-recipient-input').blur();
await expect(page.getByText(/No identity with this ID exists/)).toBeVisible({ timeout: 2 * 60_000 });
await expect(page.locator('#xfer-select-continue-btn')).toBeDisabled();
console.log('OK: nonexistent recipient refused pre-broadcast');

await page.fill('#xfer-recipient-input', recipient!);
await page.locator('#xfer-recipient-input').blur();
await expect(page.getByText('Destination identity found')).toBeVisible({ timeout: 2 * 60_000 });

await page.click('#xfer-select-continue-btn');
await expect(page.getByText('Confirm Transfer')).toBeVisible();
await page.locator('#xfer-confirm-checkbox').click({ force: true });
await page.click('#xfer-transfer-btn');

await expect(page.getByText(/Username Transferred!|Transfer Failed/)).toBeVisible({ timeout: 5 * 60_000 });
const headline = await page.locator('.xfer-headline').innerText();
console.log('RESULT:', headline);
await expect(page.getByText('Username Transferred!')).toBeVisible();
});
});
Loading
Loading