Repository navigation
Conversation
Pin the scoped asset-lock reconciliation fix and retain its typed consumed report in an actionable user message. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 29, 2026
Collaborator
|
🕓 Review not started yet because this PR is a draft.
Commit 50847c4. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Bring in the latest v1.0-dev merged into the fix/orphaned-tx base. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
When a saved deposit is reported as already used, Fund now shows that result instead of an unrelated storage error or a generic retry suggestion.
User story
As a wallet user, I can understand why an old deposit cannot fund another payment and choose another deposit or check the earlier payment.
Scenario
In Wallets → Dash Core → Asset Locks, choose Fund for a restored deposit that Platform reports as already consumed. The recovery step previously failed with a missing storage capability, hiding the result. The app now retains the recovery record and shows an actionable already-used message. This does not make spent funds available again or prove that the requested payment succeeded.
Detailed discussion
Stacked on #1028 (
fix/orphaned-tx), independently of the key-lookup fix in #1035.c0fd3b133bf37d0fc79dc8e55d8ad4b25aee662ffrom fix(wallet): require only atomic tracked-lock writes for reconciliation platform#5207. Reconciliation of an already-loaded asset lock requires onlyATOMIC_CHANGESETS | TRACKED_ASSET_LOCKS. Existing capability meanings and FFI callback requirements remain unchanged; SQLite does not claimWALLET_RESTORE.PlatformWalletError::AssetLockAlreadyConsumedto a dedicatedTaskErrorpreserving its source and explaining the result. SDK-originated consumed errors keep their existing classification.18f7f3e695e770ea5d2820aa85597d45160d1b8e.Diagnosis used read-only snapshots of the reported user databases and logs. The logs show a matching already-consumed rejection followed by the misleading persistence-capability failure. A restored Core funding transaction alone does not establish that its Platform credits remain unused; no user records are deleted or marked conclusively consumed on that evidence.
Validation:
cargo fmt --all -- --check, scoped Clippy (--locked --lib --all-features -- -D warnings), andgit diff --checkpassed.🤖 Co-authored by Claudius the Magnificent AI Agent